[router]: Make routing logic testable without fx - #123
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the router module to make routing-rule compilation and request directing testable without booting an fx.App, by lifting them into exported constructors while keeping the fx providers as thin forwarding wrappers.
Changes:
- Introduce
CompileMux(config.Routing)to compile routing rules outside of fx wiring. - Introduce
NewDirector(...)and moveDirector/Resolveimplementation intodirector.go. - Update mux/director tests to use the new constructors and adjust matcher usage to
pkg/match.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/router/mux.go | Switch Rule matching to use pkg/match.Matcher directly. |
| internal/router/mux_test.go | Update tests to use match.MustCompile and add a zero-matcher behavior test. |
| internal/router/handler.go | Generalize Target.Conn to grpc.ClientConnInterface. |
| internal/router/fx.go | Make fx providers delegate to CompileMux and NewDirector. |
| internal/router/fx_test.go | Remove invalid-routing assertions from the fx module test (moved to compile_test.go). |
| internal/router/director.go | New file: extracted Director interface + implementation and NewDirector constructor. |
| internal/router/director_test.go | Rewrite tests to use CompileMux/NewDirector from router_test package. |
| internal/router/compile.go | New file: CompileMux extracted from fx provider. |
| internal/router/compile_test.go | New tests for routing compilation behavior and error cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
`Rule` compilation and the director both lived inside anonymous fx providers in fx.go. Exercising glob syntax or metadata key handling meant booting fx apps and asserting on app.Err() substrings, and testing the director meant hand-building struct literals that skipped the pool and socket wiring, which is the part worth exercising. Lift both into their own files behind exported functions, `CompileMux` taking `config.Routing` and `NewDirector` taking its dependencies. The providers forward to them, so behaviour is unchanged.
pseudomuto
force-pushed
the
router_refactor
branch
from
August 10, 2026 14:36
4b27958 to
59a3d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rulecompilation and the director both lived inside anonymous fx providers in fx.go. Exercising glob syntax or metadata key handling meant booting fx apps and asserting on app.Err() substrings, and testing the director meant hand-building struct literals that skipped the pool and socket wiring, which is the part worth exercising.Lift both into their own files behind exported functions,
CompileMuxtakingconfig.RoutingandNewDirectortaking its dependencies. The providers forward to them, so behaviour is unchanged.