[kms]: Do not schedule rotation without a vault - #126
Merged
Conversation
The vault is built from key presence while rotation was scheduled from Encryption.Enabled, so enabling encryption with no configured key produced a nil vault and a rotation goroutine that dereferences it. The full app never hit this because whole-config validation rejects that combination, but validation lives in a module wired after this one, so the protection was ordering, not logic. Guard the hook and cover the case.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes a startup-time panic in the KMS fx module by ensuring the key-rotation lifecycle hook is only scheduled when a vault actually exists (i.e., keys are configured), even if Encryption.Enabled is true. This aligns rotation scheduling with how the vault is constructed (from key presence) and removes reliance on module ordering for safety.
Changes:
- Guard rotation scheduling in
internal/kmsso it no-ops when the injected vault isnil. - Add an fx test covering the “encryption enabled but no keys configured” case to ensure start/stop runs cleanly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/kms/fx.go | Adds a v == nil guard to prevent scheduling rotation against a nil vault. |
| internal/kms/fx_test.go | Adds a test that starts/stops an app with encryption enabled but no keys, asserting no vault and no crash. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vault is built from key presence while rotation was scheduled from Encryption.Enabled, so enabling encryption with no configured key produced a nil vault and a rotation goroutine that dereferences it.
The full app never hit this because whole-config validation rejects that combination, but validation lives in a module wired after this one, so the protection was ordering, not logic. Guard the hook and cover the case.