Guard against nil History in AppendRawHistoryNodes - #10309
Merged
Conversation
mykaul
marked this pull request as draft
May 18, 2026 12:00
Add nil check for request.History before accessing request.History.Data to prevent a panic when the caller passes a nil DataBlob.
mykaul
force-pushed
the
fix-nil-history-guard
branch
from
May 18, 2026 12:00
a5d40af to
890495e
Compare
mykaul
marked this pull request as ready for review
May 18, 2026 12:01
Contributor
Author
|
Can this be reviewed? I've hit it few times for some reason. |
prathyushpv
approved these changes
Aug 19, 2026
yiminc
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nil check for
request.Historybefore accessingrequest.History.DatainserializeAppendRawHistoryNodesRequestto prevent a panic when the caller passes a nil DataBlob.