improvements on time-skipping task regeneration - #11404
Merged
feiyang3cat merged 3 commits intoAug 19, 2026
Merged
Conversation
feiyang3cat
force-pushed
the
fix-timeskipping-task-refreshment
branch
2 times, most recently
from
August 3, 2026 19:12
5714420 to
fe9e764
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
fix-timeskipping-task-refreshment
branch
3 times, most recently
from
August 3, 2026 21:32
cf93b8b to
9a1ecea
Compare
feiyang3cat
marked this pull request as ready for review
August 3, 2026 21:32
feiyang3cat
marked this pull request as draft
August 3, 2026 21:32
feiyang3cat
force-pushed
the
fix-timeskipping-task-refreshment
branch
3 times, most recently
from
August 3, 2026 22:17
aee04c1 to
27fee51
Compare
feiyang3cat
marked this pull request as ready for review
August 3, 2026 22:17
feiyang3cat
force-pushed
the
fix-timeskipping-task-refreshment
branch
from
August 3, 2026 22:22
27fee51 to
c7855bf
Compare
…skipping regen. time-skipping: task regen didn't read EnableWorkflowExecutionTimeoutTimer
feiyang3cat
force-pushed
the
fix-timeskipping-task-refreshment
branch
from
August 17, 2026 17:47
c7855bf to
4c6faef
Compare
simvlad
approved these changes
Aug 18, 2026
| // task the start path never generated. | ||
| executionTimeoutTimer := r.mutableState.GetExecutionInfo().WorkflowExecutionExpirationTime | ||
| if !timeNotSet(executionTimeoutTimer) { | ||
| if r.config.EnableWorkflowExecutionTimeoutTimer() && !timeNotSet(executionTimeoutTimer) { |
Contributor
There was a problem hiding this comment.
Is it ok that there are more conditions here (do we need anything else): https://github.com/temporalio/temporal/blob/main/service/history/workflow/task_generator.go#L161-L166
Contributor
Author
There was a problem hiding this comment.
the only missing ones are
!isFirstRunexecutionInfo.WorkflowExecutionTimerTaskStatus == TimerTaskStatusNone
I thought they are not related to correctness just for perf refinement, but now I think we can simplify the check here to just checking WorkflowExecutionTimerTaskStatus == TimerTaskStatusCreated.
And I think we change the design here for execution timeout slightly from "checking the original logic" to "checking if there is an original timer for regeneration"
This was referenced Aug 18, 2026
feiyang3cat
force-pushed
the
fix-timeskipping-task-refreshment
branch
from
August 19, 2026 18:03
54522c0 to
77c74a0
Compare
yiminc
approved these changes
Aug 19, 2026
feiyang3cat
enabled auto-merge (squash)
August 19, 2026 18:22
davidporter-id-au
pushed a commit
to davidporter-id-au/temporal
that referenced
this pull request
Aug 24, 2026
## What changed? 1. perf improvement: no time-skipping task regen on full refresh 2. new functional test: claim Nexus HSM timers are part of in-fight nexus operation, and won’t be skipped, add functional test 3. new functional test: add a functional test to verify time skipping won't change retention time 4. trivial bug fix: time-skipping: task regen didn’t read EnableWorkflowExecutionTimeoutTimer ## Why? - correctness related No. 4 though it is an edgy case - perf related No.1 - test coverage No.2,3 ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?