Stop the SDK workers and clients the worker service starts - #11436
Draft
prathyushpv wants to merge 1 commit into
Draft
Stop the SDK workers and clients the worker service starts#11436prathyushpv wants to merge 1 commit into
prathyushpv wants to merge 1 commit into
Conversation
parentclosepolicy.Processor and scanner.Scanner dropped the reference to every SDK worker they started, so nothing could stop them and their pollers ran until the process exited. The batch activity created an SDK client per execution and never closed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
parentclosepolicy.Processorandscanner.Scannerkeep a reference to the SDK workers they start and stop them on shutdown. The batch activity closes the SDK client it creates per execution.Why?
Neither component kept a reference before, so nothing could stop the workers and their pollers ran until the process exited. The batcher leaked a client reference per activity execution, so that one accumulated for the lifetime of a server process rather than per cluster.
Part of removing the TODO ignores in
tests/leakcheck/leak_test.go(see #11322); these cover thebaseWorkerandbasePollerentries.How did you test it?
New tests cover
Processor.Stop, a failed start leaving nothing to stop, and the batch activity closing its client. Each was verified to fail when its fix is reverted.The leak suite does not exercise these paths — scanner roles are disabled in its config and it runs no batch operations — so both rest on the unit tests rather than on
make leak-test.Potential risks
Scanner.Stopnow stops up to six SDK workers sequentially, and eachStopissues aShutdownWorkerRPC. Shutdown order stops the worker service before the frontend, so this is bounded today, but it adds latency to worker-service shutdown where the frontend is already gone.