Refactor Cassandra for less open sessions#1148
Merged
Merged
Conversation
mastermanu
reviewed
Dec 31, 2020
| user: {{ default .Env.CASSANDRA_USER "" }} | ||
| password: {{ default .Env.CASSANDRA_PASSWORD "" }} | ||
| port: {{ default .Env.CASSANDRA_PORT "9042" }} | ||
| maxConns: {{ default .Env.CASSANDRA_MAX_CONNS "10" }} |
Member
There was a problem hiding this comment.
This is probably too big. I think we can leave this unset or set it to 2? What do you think
Contributor
Author
There was a problem hiding this comment.
i guess 2 is too small
mastermanu
reviewed
Dec 31, 2020
| {{- end }} | ||
| maxConns: {{ default .Env.SQL_VIS_MAX_CONNS "20" }} | ||
| maxIdleConns: {{ default .Env.SQL_VIS_MAX_IDLE_CONNS "20" }} | ||
| maxConns: {{ default .Env.SQL_VIS_MAX_CONNS "10" }} |
Member
There was a problem hiding this comment.
curious, what was the reason for this change?
Contributor
Author
There was a problem hiding this comment.
there is not many calls in visibility side
mastermanu
approved these changes
Dec 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
See above
How did you test it?
N/A
Potential risks
N/A