Make standalone activity completion callback attachment idempotent after closure - #11628
Merged
Conversation
Quinn-With-Two-Ns
marked this pull request as ready for review
August 19, 2026 14:56
Quinn-With-Two-Ns
changed the title
bergundy
approved these changes
Aug 19, 2026
awln-temporal
approved these changes
Aug 19, 2026
5 tasks
yiminc
approved these changes
Aug 20, 2026
davidporter-id-au
pushed a commit
to davidporter-id-au/temporal
that referenced
this pull request
Aug 24, 2026
…ter closure (temporalio#11628) ## What changed? Makes Standalone Activity conflict updates idempotent by recording the `requestID` when attaching callbacks or links and recognizing duplicate request IDs. I needed to add a dedicated CHASM error for ## Why? This prevents a successful attachment whose response was lost from failing on retry or duplicating/replacing callbacks and links. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Makes Standalone Activity conflict updates idempotent by recording the
requestIDwhen attaching callbacks or links and recognizing duplicate request IDs. I needed to add a dedicated CHASM error forWhy?
This prevents a successful attachment whose response was lost from failing on retry or duplicating/replacing callbacks and links.
How did you test it?
Note
Cursor Bugbot is generating a summary for commit 0e83408. Configure here.