Tag Nexus pre-dispatch failure logs - #11664
Merged
Merged
Conversation
Failures on the frontend path before namespace and endpoint resolution logged tag.Error alone, so an unknown endpoint ID, an invalid endpoint target, or a malformed URL produced a log line naming neither the endpoint nor the namespace involved. INC-1537 is the case this matters for: callers saw only "handler error (NOT_FOUND)" / "invalid endpoint target", and the server side recorded a log line with no endpoint in it, so blast radius had to be judged by reading source rather than from signals. Add the endpoint ID, endpoint name, target namespace ID, namespace, and task queue to these logs where each is known, and log the previously silent unsupported-target-type branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
stephanos
commented
Aug 19, 2026
| nc.endpointID = entry.Id | ||
| return nc, true | ||
| default: | ||
| logger.Error("unsupported Nexus endpoint target type", tag.NewStringTag("target-type", fmt.Sprintf("%T", v))) |
stephanos
commented
Aug 19, 2026
| } | ||
|
|
||
| nc, ok := h.nexusContextFromEndpoint(endpointEntry, w, r) | ||
| logger = log.With(logger, tag.Endpoint(endpointEntry.Endpoint.GetSpec().GetName())) |
Contributor
Author
There was a problem hiding this comment.
enriching them as we go seemed better than adding the tags to every call again and again
Contributor
|
Claude encountered an error after 3m 0s —— View job I'll analyze this and get back to you. |
S15
approved these changes
Aug 19, 2026
stephanos
enabled auto-merge (squash)
August 19, 2026 23:12
yiminc
approved these changes
Aug 20, 2026
davidporter-id-au
pushed a commit
to davidporter-id-au/temporal
that referenced
this pull request
Aug 24, 2026
## What changed Adds logs tags for failures on the Nexus frontend path. ## Why Have more details to correlate issues with requests. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds logs tags for failures on the Nexus frontend path.
Why
Have more details to correlate issues with requests.