Avoid refreshing workflow start tasks on later transitions - #11853
Merged
Conversation
xwduan
marked this pull request as ready for review
September 2, 2026 00:01
xwduan
added
reliability-2026
michaely520
approved these changes
Sep 2, 2026
yiminc
approved these changes
Sep 2, 2026
thestephenstanton
pushed a commit
that referenced
this pull request
Sep 2, 2026
## What changed? Workflow start task refresh now uses the workflow start versioned transition instead of the latest execution-state transition. This limits workflow start task regeneration to replication ranges that include the initial workflow transition. ## Why? Later execution-state changes can advance LastUpdateVersionedTransition while the workflow remains running. Partial task refresh then incorrectly treats the workflow as newly started and creates another WorkflowRunTimeoutTask. ## How did you test it? - [ ] built - [x] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) Ran the focused TaskRefresher unit test and the single-cluster passive replication workflow and parallel-activity scenarios with exact active/passive task comparison enabled. ## Potential risks This relies on workflow start being transition count 1, matching transition-history initialization. Full refresh still includes the initial transition and continues regenerating required workflow start tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Workflow start task refresh now uses the workflow start versioned transition instead of the latest execution-state transition. This limits workflow start task regeneration to replication ranges that include the initial workflow transition.
Why?
Later execution-state changes can advance LastUpdateVersionedTransition while the workflow remains running. Partial task refresh then incorrectly treats the workflow as newly started and creates another WorkflowRunTimeoutTask.
How did you test it?
Ran the focused TaskRefresher unit test and the single-cluster passive replication workflow and parallel-activity scenarios with exact active/passive task comparison enabled.
Potential risks
This relies on workflow start being transition count 1, matching transition-history initialization. Full refresh still includes the initial transition and continues regenerating required workflow start tasks.