Add ServiceResolver interface and corresponding ServerOption#1188
Merged
Conversation
alexshtin
force-pushed
the
feature/service-resolver
branch
from
c40051c to
3b3eeb1
Compare
alexshtin
force-pushed
the
feature/service-resolver
branch
from
36717af to
e19962d
Compare
wxing1292
approved these changes
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
ServiceResolverinterface.NoopResolverdefault implementation.WithPersistenceServiceResolverserver option to specify service resolver for persistence libraries (both Cassandra and SQL).Why?
Closes #1156.
How did you test it?
Run existing tests.
Potential risks
No risks.