Guard that ValidatorConfig.Validate checks every field - #11898
Merged
Conversation
Validate() names each required field by hand, so a field added to ValidatorConfig without a matching check stays nil and nil-panics on the request path instead of failing at construction. Assert via reflection that the error for an empty config names every field. All four fields on main are checked today; this keeps that true. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chrsmith
enabled auto-merge (squash)
September 2, 2026 17:18
stephanos
approved these changes
Sep 2, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add a new unit test for
common/callbacks.ValidatorConfig.Why?
While working on a PR that extended
ValidatorConfigand adding new fields, some bugs crept in because the new fields weren't checked in theValidatefunction. This unit test will now catch those automatically, by runningValidateon an emptyValidatorConfig, and then confirming that every field of the type is found in the error message. (Reporting that it is uninitialized.)This PR also allows me to remove this tiny change from an otherwise monstrous PR I am trying to slim down.
How did you test it?
Potential risks
None