Tune default values for dispatching worker command - #11900
Merged
Conversation
rkannan82
changed the title
rkannan82
changed the title
rkannan82
marked this pull request as ready for review
September 2, 2026 04:50
Contributor
|
Claude finished @rkannan82's task in 2m 6s —— View job Reviewed 1 file, 2 findings. |
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/worker-cmd-config-defaults
branch
from
September 2, 2026 04:52
0e6923e to
3dadf82
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rkannan82
force-pushed
the
kannan/worker-cmd-config-defaults
branch
from
September 2, 2026 04:54
3dadf82 to
9159e31
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/worker-cmd-config-defaults
branch
from
September 2, 2026 04:55
9159e31 to
a0a0134
Compare
yycptt
approved these changes
Sep 3, 2026
ShahabT
approved these changes
Sep 3, 2026
yiminc
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change default dynamic config values for worker command dispatch:
WorkerCommandsDispatchTimeout: 10s → 5sWorkerCommandsMaxAttempts: 3 → 30Why
Shorter timeout (5s): Each dispatch attempt holds an outbound executor thread waiting for a poller. If the worker is gone, that thread is blocked for nothing. Cutting from 10s to 5s means we detect missing workers faster and free up the thread sooner.
More attempts (30): The main reason for retrying is to survive matching server restarts — during a rolling restart, dispatch RPCs can fail with transient transport errors until the new pod is ready. With only 3 attempts, commands could be dropped permanently during a routine restart. 30 attempts with the default backoff (initial=1s, coefficient=1.1) spreads retries over ~2 minutes, enough to ride out a restart. Transport errors fail fast (no blocking wait), so more attempts are cheap.
🤖 Generated with Claude Code