Fix SQLite transaction cancellation test race - #11922
Merged
Merged
Conversation
stephanos
changed the title
stephanos
changed the title
stephanos
marked this pull request as ready for review
September 3, 2026 17:46
Contributor
|
Claude finished @stephanos's task in 1m 6s —— View job Reviewed 1 file, 1 finding. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
prathyushpv
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a test data race caused by passing the address of
sql.ErrNoRowstoassert.ErrorAs.Since
errors.Aswrites the matching error into its target, the assertion could mutate the package-level sentinel while parallel persistence tests read it.Use
require.ErrorIsto verify sentinel identity without mutating global state.