Skip to content

Add force flag to drop command of database tools#1196

Merged
alexshtin merged 1 commit into
temporalio:masterfrom
alexshtin:feature/dbtool-force-flag
Jan 16, 2021
Merged

Add force flag to drop command of database tools#1196
alexshtin merged 1 commit into
temporalio:masterfrom
alexshtin:feature/dbtool-force-flag

Conversation

@alexshtin

@alexshtin alexshtin commented Jan 16, 2021

Copy link
Copy Markdown
Contributor

What changed?
Added database/keyspace drop confirmation and --force flag (and -f alias) to sql and cassandra db tools. Modified Makefile accordingly.

Why?
To protect developers from accidental database/keyspace drop.

How did you test it?
Run locally.

Potential risks
No risks.

@alexshtin alexshtin force-pushed the feature/dbtool-force-flag branch from 73c349a to a649b72 Compare January 16, 2021 01:57
@alexshtin alexshtin requested a review from wxing1292 January 16, 2021 02:01
@alexshtin alexshtin enabled auto-merge (squash) January 16, 2021 02:02
@alexshtin alexshtin merged commit 38c51a4 into temporalio:master Jan 16, 2021
@alexshtin alexshtin deleted the feature/dbtool-force-flag branch January 16, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants