Fix duplication handling in ES processor#1205
Merged
alexshtin merged 6 commits intoJan 21, 2021
Merged
Conversation
wxing1292
approved these changes
Jan 20, 2021
alexshtin
force-pushed
the
feature/es-processor-fix-dup-handling
branch
from
1e7dcd0 to
0086812
Compare
wxing1292
reviewed
Jan 21, 2021
alexshtin
force-pushed
the
feature/es-processor-fix-dup-handling
branch
from
0086812 to
5642fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fix visibility task keys duplication resoler logic. Now it fails previous task and store new one for future ack/nack. Also add extra protection with
processedflag in case if same key will be acked/nacked more than once.Why?
Bug fix. In case of ES bulk operation timeout, previous implementation will be blocked forever while ack existing visibility task.
How did you test it?
Run manual tests locally with lower ES bulk operation timeout (500ms). Automated tests will be added later.
Potential risks
No risks.