Add ES logger#1209
Merged
Merged
Conversation
alexshtin
force-pushed
the
feature/add-es-logging
branch
from
d1f1d38 to
63fdb37
Compare
Ardagan
reviewed
Jan 21, 2021
| elastic6.SetBasicAuth(config.Username, config.Password), | ||
|
|
||
| elastic6.SetErrorLog(newErrorLogger(logger)), | ||
| // elastic6.SetInfoLog(newInfoLogger(logger)), |
Ardagan
reviewed
Jan 21, 2021
| elastic.SetBasicAuth(config.Username, config.Password), | ||
|
|
||
| elastic.SetErrorLog(newErrorLogger(logger)), | ||
| // elastic.SetInfoLog(newInfoLogger(logger)), |
Contributor
Author
There was a problem hiding this comment.
I want it to be there in case I will want to see info logs. There is not log level in ES. The only way I can control is to set these loggers or not.
Contributor
There was a problem hiding this comment.
+1 to Remove commented code
Contributor
Author
There was a problem hiding this comment.
Added clarifying comment.
wxing1292
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added error logger to ES client.
Why?
Improve visibility of ES errors.
How did you test it?
Run locally with simulated ES failures (ES is down).
Potential risks
No risks.