Fix wrong context package and update go to 1.14#253
Merged
alexshtin merged 2 commits intotemporalio:masterfrom Mar 27, 2020
Merged
Fix wrong context package and update go to 1.14#253alexshtin merged 2 commits intotemporalio:masterfrom
alexshtin merged 2 commits intotemporalio:masterfrom
Conversation
Conflicts: go.mod
alexshtin
commented
Mar 27, 2020
| "go.temporal.io/temporal-proto/enums" | ||
| "go.temporal.io/temporal-proto/serviceerror" | ||
| "go.temporal.io/temporal-proto/workflowservice" | ||
| "golang.org/x/net/context" |
Contributor
Author
There was a problem hiding this comment.
This package should never be used.
Contributor
|
Check https://golang.org/cmd/fix/ |
markmark206
approved these changes
Mar 27, 2020
Contributor
Author
|
I will add this tool to our list of checkers. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Using correct
contextpackage now.Why?
Wrong
contextpackage was used in one file.How did you test it?
Run tests.
Potential risks
No risks.