Skip to content

Fix wrong context package and update go to 1.14#253

Merged
alexshtin merged 2 commits intotemporalio:masterfrom
alexshtin:fix/wrong-context-package
Mar 27, 2020
Merged

Fix wrong context package and update go to 1.14#253
alexshtin merged 2 commits intotemporalio:masterfrom
alexshtin:fix/wrong-context-package

Conversation

@alexshtin
Copy link
Copy Markdown
Contributor

What changed?
Using correct context package now.

Why?
Wrong context package was used in one file.

How did you test it?
Run tests.

Potential risks
No risks.

"go.temporal.io/temporal-proto/enums"
"go.temporal.io/temporal-proto/serviceerror"
"go.temporal.io/temporal-proto/workflowservice"
"golang.org/x/net/context"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package should never be used.

@mindaugasrukas
Copy link
Copy Markdown
Contributor

Check https://golang.org/cmd/fix/

$ go tool fix -h 2>&1 | grep context
context
	Change imports of golang.org/x/net/context to context

@alexshtin
Copy link
Copy Markdown
Contributor Author

Check https://golang.org/cmd/fix/

I will add this tool to our list of checkers. Thanks!

@alexshtin alexshtin merged commit 56742ce into temporalio:master Mar 27, 2020
@alexshtin alexshtin deleted the fix/wrong-context-package branch March 27, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants