CHASM: improve support for implementing Terminate method by yycptt · Pull Request #9351 · temporalio/temporal

yycptt · 2026-02-19T01:53:47Z

What changed?

Define TerminableComponent and RootComponent interface
Make metrics handler available through chasm context
Add support for passing key value pairs with chasm context similar to context.Context
Add support for specifying key values pairs that will always be available in the Context when a component is accessed.
Add requestID to TerminateComponentRequest

Why?

Improve support for library authors to implement the Terminate method.

How did you test it?

yycptt · 2026-02-19T01:55:21Z

chasm/registrable_task.go

+			registry *Registry,
+		) (bool, error) {
+			return validator.Validate(
+				augmentContextForComponent(ctx, component, registry),


we can do the same thing for registered tasks as well.

yycptt · 2026-02-19T02:01:51Z

chasm/registrable_component.go

+// This is useful for propagating values needed for those processing logic but are not avaiable via the
+// component's struct definition, such as configurations.
+func WithContextValue(
+	keyVals map[any]any,


since the keyVals are the same across component instances, we don't really need to use context.Context.Value() to implement this which adds overhead. The chasmContext.Value() method can just check the registry for a key. The semantic will be different from context.Context though.

bergundy

Had some small suggestions but otherwise LGTM.

bergundy · 2026-02-20T17:30:44Z

chasm/context.go

+// ContextWithValue returns a new Context with the given key-value pair added.
+// Added key-value pairs will be accessible via the Value() method on the returned Context,
+// and the behavior of the key-value pair is the same as context.Context.WithValue().
+func ContextWithValue[C Context](c C, key any, value any) C {


You could consider structuring this as the Go stdlib does this: https://cs.opensource.google/go/go/+/refs/tags/go1.26.0:src/context/context.go;l=727.

You should be able to do this with type valueCtx[C Context] struct.

hmm... I tried this before but embedding C directly into the valueCtx struct is not allowed.

type valueCtx[C Context] struct { C ctx context.Context }

that won't compile..... so valueCtx still can't sometimes implement Context and sometimes implement MutableContext...

Hmmm you can wrap it with base C but that's not critical IMHO.

chasm/context.go

bergundy · 2026-02-20T17:38:32Z

chasm/registrable_component.go

+//
+// This is useful for propagating values needed for those processing logic but are not avaiable via the
+// component's struct definition, such as configurations.
+func WithContextValue(


Suggested change

func WithContextValue(

func WithContextValues(

But I'm also wondering if we want a function that takes a context and returns a context here. What you have is fine for now though.

Renamed.

if we want a function that takes a context and returns a context here

Not sure I follow the use case here as this one is a registration option. Happy to add one when we have a need for it.

Yeah the idea is that you can inject a metrics handler that is bound to the current request's namespace instead of passing in bits to construct that handler for example:

temporal/chasm/lib/activity/activity.go

Lines 298 to 303 in 6875191

metricsHandler := enrichMetricsHandler(

a,

event.MetricsHandlerBuilderParams.Handler,

event.MetricsHandlerBuilderParams.NamespaceName,

metrics.HistoryRespondActivityTaskCompletedScope,

event.MetricsHandlerBuilderParams.BreakdownMetricsByTaskQueue)

* origin/main: CHASM: improve support for implementing Terminate method (#9351) Add testhooks package documentation (#9373) Improve re-usability of ringpop membership & PerNamespaceWorker (#9321) Fairness counter: fix heap bug in map counter (#9370) Avoid finalGC when ack level is zero (#9371) Fairness counter: persist top K keys (#9188) Flake Fix: In Reactivation Cache tests, wait for appropriate delays when confirming expected drainage status (#9352) Include transient and speculative WFT events in GetWorkflowExecutionHistoryResponse (#9325) Fix flaky test TestTransitionDuringTransientTask (#9356) Add per-workflow scheduler for history task processing (#9141) Populate currentAttemptScheduledTime on PollActivityTaskQueueResponse for standalone activities (#9333) Standalone activity heartbeating bug fix (#9354) Revert "Last part of making Nexus work OOTB" (#9343) Convert flake report from Python to Go (#9334) Do not enforce payload limits for system nexus endpoint (#9344)

…9351) ## What changed? - Define TerminableComponent and RootComponent interface - Make metrics handler available through chasm context - Add support for passing key value pairs with chasm context similar to context.Context - Add support for specifying key values pairs that will always be available in the Context when a component is accessed. - Add requestID to TerminateComponentRequest ## Why? - Improve support for library authors to implement the Terminate method. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [x] added new functional test(s)

yycptt commented Feb 19, 2026

View reviewed changes

yycptt requested a review from bergundy February 19, 2026 02:03

yycptt assigned awln-temporal and unassigned awln-temporal Feb 19, 2026

yycptt requested a review from awln-temporal February 19, 2026 02:03

bergundy approved these changes Feb 20, 2026

View reviewed changes

yycptt force-pushed the chasm-terminate branch from f5af4f6 to 7b7eb67 Compare February 23, 2026 05:46

CHASM: improve support for implementing Terminate method

3d3f033

yycptt force-pushed the chasm-terminate branch from 7b7eb67 to 3d3f033 Compare February 23, 2026 05:50

fix lint

f3e9b2b

yycptt marked this pull request as ready for review February 23, 2026 06:02

yycptt requested review from a team as code owners February 23, 2026 06:02

fix side effect task, fix tests

7550eaf

yycptt merged commit 6875191 into temporalio:main Feb 23, 2026
46 checks passed

yycptt deleted the chasm-terminate branch February 23, 2026 07:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CHASM: improve support for implementing Terminate method#9351

CHASM: improve support for implementing Terminate method#9351
yycptt merged 3 commits intotemporalio:mainfrom
yycptt:chasm-terminate

yycptt commented Feb 19, 2026 •

edited

Loading

Uh oh!

yycptt Feb 19, 2026

Uh oh!

yycptt Feb 19, 2026

Uh oh!

bergundy left a comment

Uh oh!

bergundy Feb 20, 2026

Uh oh!

yycptt Feb 23, 2026

Uh oh!

bergundy Feb 23, 2026

Uh oh!

Uh oh!

Uh oh!

bergundy Feb 20, 2026

Uh oh!

bergundy Feb 20, 2026

Uh oh!

yycptt Feb 23, 2026

Uh oh!

bergundy Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	metricsHandler := enrichMetricsHandler(
	a,
	event.MetricsHandlerBuilderParams.Handler,
	event.MetricsHandlerBuilderParams.NamespaceName,
	metrics.HistoryRespondActivityTaskCompletedScope,
	event.MetricsHandlerBuilderParams.BreakdownMetricsByTaskQueue)

Conversation

yycptt commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

Why?

How did you test it?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergundy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yycptt commented Feb 19, 2026 •

edited

Loading