Improve re-usability of ringpop membership & PerNamespaceWorker by 02strich · Pull Request #9321 · temporalio/temporal

02strich · 2026-02-13T18:58:51Z

What changed?

This makes the ServiceName to ServiceType mapping in the Ringpop membership implementation more extensible, and exports the worker-service's PerNamespaceWorker.

Why?

As the code base grows, it becomes useful to enable building system services in seperate repositories (just to manage growth).

This approach unblocks re-use of membership and PerNamespaceWorker capabilities that are more generically useful than solely inside the server.

How did you test it?

CLAassistant · 2026-02-13T18:58:59Z

All committers have signed the CLA.

common/membership/ringpop/monitor.go

service/worker/pernamespaceworker.go

dnr · 2026-02-18T00:11:50Z

service/worker/pernamespaceworker.go

 }

-func (wm *perNamespaceWorkerManager) Start(
+func (wm *PerNamespaceWorkerManager) Start(


you should change the key in the AddListener call to something unique in case these end up in the same process. I like to use fmt.Sprintf("%p", wm)

ah gotcha, made the change

This updates the mapping from service name to ringpop role to using a map instead of an if-else chain. The map enables distributed configurability instead of depending on defining all scenarios in this single place.

bergundy

Approved with a suggestion.

bergundy · 2026-02-20T17:09:09Z

common/membership/ringpop/monitor.go

+var (
+	serviceNameToServiceTypeEnumMap = map[primitives.ServiceName]persistence.ServiceType{}
+)
+
+func RegisterServiceNameToServiceTypeEnum(serviceName primitives.ServiceName, serviceType persistence.ServiceType) {
+	serviceNameToServiceTypeEnumMap[serviceName] = serviceType
+}
+
+func init() {
+	RegisterServiceNameToServiceTypeEnum(primitives.AllServices, persistence.All)
+	RegisterServiceNameToServiceTypeEnum(primitives.FrontendService, persistence.Frontend)
+	RegisterServiceNameToServiceTypeEnum(primitives.InternalFrontendService, persistence.InternalFrontend)
+	RegisterServiceNameToServiceTypeEnum(primitives.HistoryService, persistence.History)
+	RegisterServiceNameToServiceTypeEnum(primitives.MatchingService, persistence.Matching)
+	RegisterServiceNameToServiceTypeEnum(primitives.WorkerService, persistence.Worker)
+}


Suggested change

var (

serviceNameToServiceTypeEnumMap = map[primitives.ServiceName]persistence.ServiceType{}

)

func RegisterServiceNameToServiceTypeEnum(serviceName primitives.ServiceName, serviceType persistence.ServiceType) {

serviceNameToServiceTypeEnumMap[serviceName] = serviceType

}

func init() {

RegisterServiceNameToServiceTypeEnum(primitives.AllServices, persistence.All)

RegisterServiceNameToServiceTypeEnum(primitives.FrontendService, persistence.Frontend)

RegisterServiceNameToServiceTypeEnum(primitives.InternalFrontendService, persistence.InternalFrontend)

RegisterServiceNameToServiceTypeEnum(primitives.HistoryService, persistence.History)

RegisterServiceNameToServiceTypeEnum(primitives.MatchingService, persistence.Matching)

RegisterServiceNameToServiceTypeEnum(primitives.WorkerService, persistence.Worker)

}

var serviceNameToServiceTypeEnumMap = map[primitives.ServiceName]persistence.ServiceType{

primitives.AllServices: persistence.All,

primitives.FrontendService: persistence.Frontend,

primitives.InternalFrontendService: persistence.InternalFrontend,

primitives.HistoryService: persistence.History,

primitives.MatchingService: persistence.Matching,

primitives.WorkerService: persistence.Worker,

}

there still needs to be a RegisterServiceNameToServiceTypeEnum, that's the whole point of this change

bergundy · 2026-02-20T17:10:50Z

common/membership/ringpop/monitor.go

+	RegisterServiceNameToServiceTypeEnum(primitives.WorkerService, persistence.Worker)
+}
+
+func serviceNameToServiceTypeEnum(name primitives.ServiceName) (persistence.ServiceType, error) {


Seems like a redundant helper but 🤷

wanted to keep the changes contained - can remove it down the line

dnr

couple nitpicks but no blockers, so approving now

common/membership/ringpop/monitor.go

dnr · 2026-02-20T22:21:41Z

common/membership/ringpop/monitor.go

+var (
+	serviceNameToServiceTypeEnumMap = map[primitives.ServiceName]persistence.ServiceType{}
+)
+
+func RegisterServiceNameToServiceTypeEnum(serviceName primitives.ServiceName, serviceType persistence.ServiceType) {
+	serviceNameToServiceTypeEnumMap[serviceName] = serviceType
+}
+
+func init() {
+	RegisterServiceNameToServiceTypeEnum(primitives.AllServices, persistence.All)
+	RegisterServiceNameToServiceTypeEnum(primitives.FrontendService, persistence.Frontend)
+	RegisterServiceNameToServiceTypeEnum(primitives.InternalFrontendService, persistence.InternalFrontend)
+	RegisterServiceNameToServiceTypeEnum(primitives.HistoryService, persistence.History)
+	RegisterServiceNameToServiceTypeEnum(primitives.MatchingService, persistence.Matching)
+	RegisterServiceNameToServiceTypeEnum(primitives.WorkerService, persistence.Worker)
+}


there still needs to be a RegisterServiceNameToServiceTypeEnum, that's the whole point of this change

dnr · 2026-02-20T22:24:32Z

service/worker/fx.go

+
+func PerNamespaceWorkerManagerProvider(params perNamespaceWorkerManagerInitParams) *PerNamespaceWorkerManager {
+	return NewPerNamespaceWorkerManager(
+		params.Logger,


could just pass params as a whole, so there's fewer places to change when adding dependencies? I guess this separates the fx stuff more cleanly, so either way

yeah the goal was separating the FX a tiny bit more so it is not hard assumed which fields come FX and which come from somewhere else

service/worker/pernamespaceworker.go

Making the PerNamespaceWorker helper from the worker service exported so it can be re-used by other components.

* origin/main: CHASM: improve support for implementing Terminate method (#9351) Add testhooks package documentation (#9373) Improve re-usability of ringpop membership & PerNamespaceWorker (#9321) Fairness counter: fix heap bug in map counter (#9370) Avoid finalGC when ack level is zero (#9371) Fairness counter: persist top K keys (#9188) Flake Fix: In Reactivation Cache tests, wait for appropriate delays when confirming expected drainage status (#9352) Include transient and speculative WFT events in GetWorkflowExecutionHistoryResponse (#9325) Fix flaky test TestTransitionDuringTransientTask (#9356) Add per-workflow scheduler for history task processing (#9141) Populate currentAttemptScheduledTime on PollActivityTaskQueueResponse for standalone activities (#9333) Standalone activity heartbeating bug fix (#9354) Revert "Last part of making Nexus work OOTB" (#9343) Convert flake report from Python to Go (#9334) Do not enforce payload limits for system nexus endpoint (#9344)

…oralio#9321) ## What changed? This makes the ServiceName to ServiceType mapping in the Ringpop membership implementation more extensible, and exports the worker-service's PerNamespaceWorker. ## Why? As the code base grows, it becomes useful to enable building system services in seperate repositories (just to manage growth). This approach unblocks re-use of membership and PerNamespaceWorker capabilities that are more generically useful than solely inside the server. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)

Merges temporalio/temporal main branch up to df2e384. Key upstream changes: - Customizable serialization (temporalio#8426): EncodingTypeFromEnv(), EncodingType() on Encoder - Per-workflow scheduler for history task processing (temporalio#9141) - Ringpop membership & PerNamespaceWorker reusability (temporalio#9321) - Transient/speculative WFT events in history response (temporalio#9325) - Per-check diagnostics in DeepHealthCheck API (temporalio#9350) - Fairness counter heap bug fix (temporalio#9370) - System nexus endpoint (temporalio#9002) - Mixed brain non-blocking (temporalio#9406) - interface{} → any across persistence layer - Various CI, test, and chasm improvements DSQL fork code preserved: - TxRetryPolicy/TxRetryMetrics/TxRetryPolicyProvider (common.go) - ExecutionStoreCreator interface and factory wrapping (factory.go) - OCC-aware lockShard bypass (shard.go) - PoolSizeHint ephemeral pool sizing (version_checker.go) - DSQL-safe InitializeSystemNamespaces (metadata_manager.go) - Snowflake ID generator (idgenerator.go) - RegisterPluginAlias (store.go) - Full DSQL plugin (sqlplugin/dsql/)

…oralio#9321) ## What changed? This makes the ServiceName to ServiceType mapping in the Ringpop membership implementation more extensible, and exports the worker-service's PerNamespaceWorker. ## Why? As the code base grows, it becomes useful to enable building system services in seperate repositories (just to manage growth). This approach unblocks re-use of membership and PerNamespaceWorker capabilities that are more generically useful than solely inside the server. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)

02strich force-pushed the stefan/ext-service branch from 8c72508 to 33567ce Compare February 17, 2026 22:54

02strich changed the title ~~Add support for services outside of this code base~~ Improve re-usability of ringpop membership & PerNamespaceWorker Feb 17, 2026

02strich force-pushed the stefan/ext-service branch 2 times, most recently from d708085 to c6be5b5 Compare February 17, 2026 23:48

dnr reviewed Feb 18, 2026

View reviewed changes

02strich closed this Feb 18, 2026

02strich reopened this Feb 18, 2026

02strich force-pushed the stefan/ext-service branch from c6be5b5 to 835a49c Compare February 18, 2026 18:32

Make ringpop role mapping extensible

ddaf6a0

This updates the mapping from service name to ringpop role to using a map instead of an if-else chain. The map enables distributed configurability instead of depending on defining all scenarios in this single place.

02strich force-pushed the stefan/ext-service branch 2 times, most recently from f2ce416 to 5759690 Compare February 18, 2026 18:50

02strich marked this pull request as ready for review February 18, 2026 19:16

02strich requested review from a team as code owners February 18, 2026 19:16

02strich requested review from bergundy and dnr February 20, 2026 17:03

bergundy approved these changes Feb 20, 2026

View reviewed changes

dnr approved these changes Feb 20, 2026

View reviewed changes

Export PerNamespaceWorker

2cebb48

Making the PerNamespaceWorker helper from the worker service exported so it can be re-used by other components.

02strich force-pushed the stefan/ext-service branch from 5759690 to 2cebb48 Compare February 20, 2026 23:04

02strich merged commit aff1163 into main Feb 21, 2026
46 checks passed

02strich deleted the stefan/ext-service branch February 21, 2026 00:41

iw mentioned this pull request Mar 19, 2026

Merge upstream temporalio/temporal (124 commits, up to df2e384da) iw/temporal#20

Merged

Conversation

02strich commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

Why?

How did you test it?

Uh oh!

CLAassistant commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergundy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

02strich commented Feb 13, 2026 •

edited

Loading

CLAassistant commented Feb 13, 2026 •

edited

Loading