Return empty response when ListWorkersEnabled is false#9531
Merged
Conversation
Instead of returning an Unimplemented error when the ListWorkers dynamic config is disabled, return an empty response from both ListWorkers and DescribeWorker APIs. This allows callers to gracefully handle the feature being disabled. Made-with: Cursor
ShahabT
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
When
ListWorkersEnableddynamic config is disabled for a namespace,ListWorkersandDescribeWorkerAPIs now return empty responses instead ofUnimplementederrors.Why?
Callers shouldn't need to handle errors for a feature that's simply not enabled yet.
How did you test it?
Potential risks
None