Deprecate ListWorkersEnabled flag; always allow ListWorkers/DescribeWorker#9544
Open
Deprecate ListWorkersEnabled flag; always allow ListWorkers/DescribeWorker#9544
Conversation
…orker Remove the ListWorkersEnabled dynamic config flag and the flag guard from ListWorkers and DescribeWorker APIs. These read-only APIs naturally return empty results (ListWorkers) or NotFound (DescribeWorker) when no heartbeat data exists, so gating them behind a separate flag is unnecessary. The write path (RecordWorkerHeartbeat) is already gated by WorkerHeartbeatsEnabled. Add functional tests verifying ListWorkers returns empty and DescribeWorker returns NotFound when no heartbeats have been recorded. Made-with: Cursor
Preserve the dynamic config key so existing deployments that set it don't get config parse errors. Mark it as deprecated since ListWorkers and DescribeWorker are now always enabled. Made-with: Cursor
rkannan82
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Deprecate
ListWorkersEnableddynamic config flag.ListWorkersandDescribeWorkerAPIs are now always enabled — they naturally return empty/NotFound when no heartbeat data exists, so the flag is unnecessary. The write path is already gated byWorkerHeartbeatsEnabled.Follow-up to #9531.
How did you test it?
Potential risks
None — the flag defaulted to
trueand the config key is preserved (deprecated) to avoid parse errors.