Conversation
stephanos
commented
Mar 17, 2026
| // Fields used by SDK based tests. | ||
| sdkClient sdkclient.Client | ||
| worker sdkworker.Worker | ||
| sdkWorker sdkworker.Worker |
stephanos
commented
Mar 17, 2026
|
|
||
| func (s *FunctionalTestBase) Worker() sdkworker.Worker { | ||
| return s.worker | ||
| func (s *FunctionalTestBase) SdkWorker() sdkworker.Worker { |
spkane31
approved these changes
Mar 18, 2026
stephanos
force-pushed
the
stephanos/test-sdk-worker
branch
from
fdcc9fb to
a0b2dcb
Compare
stephanos
added a commit
that referenced
this pull request
Mar 20, 2026
## What changed? Rename `FunctionalTestBase`'s `Worker` to `SdkWorker`. ## Why? The new TestEnv uses `SdkClient/SdkWorker`; with this change the diff on individual suite migrations is greatly reduced. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
birme
pushed a commit
to eyevinn-osaas/temporal
that referenced
this pull request
Mar 23, 2026
## What changed? Rename `FunctionalTestBase`'s `Worker` to `SdkWorker`. ## Why? The new TestEnv uses `SdkClient/SdkWorker`; with this change the diff on individual suite migrations is greatly reduced. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
stephanos
added a commit
that referenced
this pull request
Mar 23, 2026
## What changed? Rename `FunctionalTestBase`'s `Worker` to `SdkWorker`. ## Why? The new TestEnv uses `SdkClient/SdkWorker`; with this change the diff on individual suite migrations is greatly reduced. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
pashafateev
added a commit
that referenced
this pull request
Apr 1, 2026
…branch SdkWorker() was renamed from Worker() in PR #9558 on main but that refactor is not on this release branch.
pashafateev
added a commit
that referenced
this pull request
Apr 1, 2026
…branch SdkWorker() was renamed from Worker() in PR #9558 on main but that refactor is not on this release branch.
pashafateev
added a commit
that referenced
this pull request
Apr 2, 2026
…branch SdkWorker() was renamed from Worker() in PR #9558 on main but that refactor is not on this release branch.
tdyas
pushed a commit
that referenced
this pull request
Apr 2, 2026
…branch (#9792) ## Summary `SdkWorker()` was renamed from `Worker()` in PR #9558 on main, but that refactor is not on this release branch. The security fix cherry-pick (PR #9767) introduced `s.SdkWorker()` in the test file, which doesn't compile here. One-line fix: `s.SdkWorker()` → `s.Worker()` in `tests/activity_api_batch_unpause_test.go:246`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Rename
FunctionalTestBase'sWorkertoSdkWorker.Why?
The new TestEnv uses
SdkClient/SdkWorker; with this change the diff on individual suite migrations is greatly reduced.How did you test it?