Merged
Conversation
spkane31
approved these changes
Apr 1, 2026
pashafateev
pushed a commit
that referenced
this pull request
Apr 1, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
Merged
temporal-cicd bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
pashafateev
pushed a commit
that referenced
this pull request
Apr 1, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
chaptersix
pushed a commit
that referenced
this pull request
Apr 2, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
chaptersix
pushed a commit
to chaptersix/temporal
that referenced
this pull request
Apr 2, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
tdyas
pushed a commit
that referenced
this pull request
Apr 2, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
Merged
temporal-cicd bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io>
tdyas
pushed a commit
that referenced
this pull request
Apr 2, 2026
…branch (#9792) ## Summary `SdkWorker()` was renamed from `Worker()` in PR #9558 on main, but that refactor is not on this release branch. The security fix cherry-pick (PR #9767) introduced `s.SdkWorker()` in the test file, which doesn't compile here. One-line fix: `s.SdkWorker()` → `s.Worker()` in `tests/activity_api_batch_unpause_test.go:246`
tdyas
pushed a commit
that referenced
this pull request
Apr 3, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Sean Kane <sean.kane@temporal.io> (cherry picked from commit e69b0c7)
tdyas
added a commit
that referenced
this pull request
Apr 3, 2026
## What changed and why? ### **Security** - Check namespaces in batch workflow ([CVE-2026-5199](https://www.cve.org/cverecord?id=CVE-2026-5199), LOW) ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces. > > **Overview** > Adds strict namespace isolation checks to the batcher worker: `BatchActivityWithProtobuf` now validates that `NamespaceId` *and* any provided `Request.Namespace`/`AdminRequest.Namespace` match the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type). > > Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert `startTaskProcessor` uses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3a52696. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Carly de Frondeville <carly.defrondeville@temporal.io> Co-authored-by: Sean Kane <sean.kane@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why?
Security
How did you test it?
Note
Medium Risk
Tightens namespace validation for privileged batcher activities to prevent cross-namespace request spoofing; mistakes here could block legitimate batch jobs or still leave gaps if other call paths use unvalidated namespaces.
Overview
Adds strict namespace isolation checks to the batcher worker:
BatchActivityWithProtobufnow validates thatNamespaceIdand any providedRequest.Namespace/AdminRequest.Namespacematch the worker’s bound namespace, and consistently uses that bound namespace for downstream frontend calls (including reset-by-type).Adds targeted tests: new unit tests to reject mismatched namespace strings and to assert
startTaskProcessoruses the worker namespace for signals, plus a functional test ensuring a batch terminate in one namespace does not affect workflows in another.Written by Cursor Bugbot for commit 3a52696. This will update automatically on new commits. Configure here.