Add CreateWorkerDeploymentVersion API with compute config and CREATED status#9651
Add CreateWorkerDeploymentVersion API with compute config and CREATED status#9651ShahabT merged 11 commits intoserverlessfrom
Conversation
02strich
left a comment
There was a problem hiding this comment.
I am not seeing the place where the actual worker controller instance would be created/deleted - can you add that?
Also for the risk of just having it missed it: is there anything in the read path that needs to change? Today the API doesn't really return much status about the compute config so maybe not...
| return &workflowservice.CreateWorkerDeploymentVersionResponse{}, nil | ||
| } | ||
|
|
||
| func (wh *WorkflowHandler) UpdateWorkerDeploymentVersionComputeConfig( |
There was a problem hiding this comment.
do you plan to funnel this through the worker deployment version WF as well, or do the update directly?
There was a problem hiding this comment.
funnel through. describe version need to have up-to-date compute info.
| args.VersionState.ComputeConfig = computeConfig | ||
| args.VersionState.Status = enumspb.WORKER_DEPLOYMENT_VERSION_STATUS_CREATED |
There was a problem hiding this comment.
seems inconsistent to have these here and not in makeVersionWorkflowArgs?
There was a problem hiding this comment.
do you also need to update common/api/metadata.go?
Summary
CreateWorkerDeploymentVersionfrontend API that explicitly creates a version in an existing deployment with optional compute config and scaling group validationWORKER_DEPLOYMENT_VERSION_STATUS_CREATEDstatus for explicitly created versions that transitions toINACTIVEonce a poller registers a task queueValidateWorkerDeploymentVersionComputeConfiginutil.go)Test plan
CreateWorkerDeploymentVersionsuccess, idempotency, and rejection cases inworkflow_test.goworker_deployment_version_test.goDescribeWorkerDeploymentVersion