Implement Validate API and call Update/Delete on WCI#9759
Merged
ShahabT merged 7 commits intotemporalio:serverlessfrom Apr 1, 2026
Merged
Implement Validate API and call Update/Delete on WCI#9759ShahabT merged 7 commits intotemporalio:serverlessfrom
ShahabT merged 7 commits intotemporalio:serverlessfrom
Conversation
rkannan82
reviewed
Apr 2, 2026
| if err != nil { | ||
| if computeConfig != nil { | ||
| deleteCtx := workflow.WithActivityOptions(ctx, defaultActivityOptions) | ||
| err = workflow.ExecuteActivity(deleteCtx, d.a.DeleteWorkerControllerInstanceFromDeployment, &deploymentspb.DeleteWorkerControllerInstanceInput{ |
Contributor
There was a problem hiding this comment.
This overwrites the original error. So if deletion succeeds, we don't return error. Is this intentional?
| func (a *Activities) UpdateWorkerControllerInstanceFromDeployment(ctx context.Context, input *deploymentspb.UpdateWorkerControllerInstanceInput) error { | ||
| upserts := scalingGroupUpdatesToWCI(input.GetUpsertScalingGroups()) | ||
| if err := a.WorkerControllerInstanceClient.UpdateWorkerControllerInstance(ctx, a.namespace, input.GetVersion(), nil, input.GetIdentity(), upserts, input.GetRemoveScalingGroups()); err != nil { | ||
| return temporal.NewApplicationError(err.Error(), errInvalidComputeConfig) |
Contributor
There was a problem hiding this comment.
nit: We are treating even rpc errors as invalid config. Why is that?
ShahabT
added a commit
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
last_modifier_identityfor VersionWhy?
Needed for server-scaled workers
How did you test it?
Potential risks
None