fix(workflow): remove max height from event history table and default to timeline#3184
Merged
rossnelson merged 3 commits intomainfrom Feb 24, 2026
Merged
fix(workflow): remove max height from event history table and default to timeline#3184rossnelson merged 3 commits intomainfrom
rossnelson merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
I think we need to do an audit of routeForEventHistory use and switch to a new routeForTimeline if that should be the default |
rossedfort
approved these changes
Feb 24, 2026
… to timeline Remove the constrained max-height on the event history table so the window scrolls instead of the table scrolling independently. Also update links that navigate to other workflows to point to the Timeline tab instead of Event History: - Default workflow detail redirect - Child workflow and execution links in event details - Reset workflow success link
rossnelson
force-pushed
the
fix/event-history-window-scroll
branch
from
fae0b52 to
c1e741d
Compare
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| } else if (linkType === 'child-workflow') { | ||
| return routeForEventHistory({ | ||
| return routeForTimeline({ | ||
| namespace: ns, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| return routeForEventHistory({ | ||
| return routeForTimeline({ | ||
| namespace: ns, | ||
| workflow: attrs.workflowExecutionWorkflowId, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| href={routeForEventHistory({ | ||
| href={routeForTimeline({ | ||
| namespace, | ||
| workflow: workflowId, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
Contributor
|
When an EventLink points to another workflow without a specific event, default to the timeline tab instead of event history.
| }); | ||
| } else { | ||
| return routeForEventHistory({ | ||
| return routeForTimeline({ |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| } else { | ||
| return routeForEventHistory({ | ||
| return routeForTimeline({ | ||
| namespace: link.workflowEvent.namespace, |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| return routeForEventHistory({ | ||
| return routeForTimeline({ | ||
| namespace: link.workflowEvent.namespace, | ||
| workflow: link.workflowEvent.workflowId, |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
Alex-Tideman
approved these changes
Feb 24, 2026
temporal-cicd bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0 Bump type: minor Changes included: - [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184) - [`39402461`](3940246) Add back event history legend and auto refresh (#3187) - [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188) - [`0ee9b8e7`](0ee9b8e) encode activity id (#3191) - [`dbe3114e`](dbe3114) Fix workflow errors (#3190) - [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)
rossedfort
added a commit
that referenced
this pull request
Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0 Bump type: minor Changes included: - [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184) - [`39402461`](3940246) Add back event history legend and auto refresh (#3187) - [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188) - [`0ee9b8e7`](0ee9b8e) encode activity id (#3191) - [`dbe3114e`](dbe3114) Fix workflow errors (#3190) - [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189) Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxHeighton the event history table (calc(100vh - 555px)) so the browser window scrolls instead of the table scrolling independently/timelineChanges
event-summary-table.svelte—maxHeightchanged from conditional calc to"none"workflow-history-layout.svelte— removedminimizedprop fromEventSummaryTable[run]/+page.ts— redirect/history→/timelineevent-details-link.svelte— execution and child-workflow links userouteForTimelineinstead ofrouteForEventHistoryworkflow-header.svelte— reset workflow success link usesrouteForTimelineTest plan