Skip to content

Add back event history legend and auto refresh#3187

Merged
laurakwhit merged 5 commits intomainfrom
add-back-event-history-legend
Feb 25, 2026
Merged

Add back event history legend and auto refresh#3187
laurakwhit merged 5 commits intomainfrom
add-back-event-history-legend

Conversation

@laurakwhit
Copy link
Collaborator

@laurakwhit laurakwhit commented Feb 25, 2026

Description & motivation 💭

Screenshots (if applicable) 📸

Timeline Event History
Screenshot 2026-02-24 at 8 24 00 PM Screenshot 2026-02-24 at 8 24 23 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from a team and rossedfort as code owners February 25, 2026 03:38
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 25, 2026 4:35pm

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 25, 2026

Warnings
⚠️

📊 Strict Mode: 23 errors in 6 files (2.1% of 1113 total)

src/lib/components/event/event-summary-row.svelte (5)
  • L131:6: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  • L168:23: Parameter 'event' implicitly has an 'any' type.
  • L180:30: Parameter 'group' implicitly has an 'any' type.
  • L180:37: Parameter 'hoveredEventId' implicitly has an 'any' type.
  • L313:16: Type 'ITimestamp | null | undefined' is not assignable to type 'ITimestamp'.
src/lib/components/event/pending-activity-summary-row.svelte (5)
  • L116:12: 'event.attempt' is possibly 'null' or 'undefined'.
  • L123:12: 'event.attempt' is possibly 'null' or 'undefined'.
  • L130:13: 'event.attempt' is possibly 'null' or 'undefined'.
  • L132:12: Type 'ITimestamp | null | undefined' is not assignable to type 'ITimestamp'.
  • L143:8: Type 'string | undefined' is not assignable to type 'string | Record<string, unknown> | IPayloads'.
src/lib/components/event/pending-nexus-summary-row.svelte (1)
  • L117:16: Type 'ITimestamp | null | undefined' is not assignable to type 'ITimestamp'.
src/lib/components/lines-and-dots/svg/timeline-graph-row.svelte (7)
  • L100:20: 'distance' is possibly 'null'.
  • L100:31: 'workflowDistance' is possibly 'null'.
  • L111:20: 'distance' is possibly 'null'.
  • L111:31: 'workflowDistance' is possibly 'null'.
  • L151:29: 'activityTaskScheduled.attributes.attempt' is possibly 'null' or 'undefined'.
  • L244:12: 'pendingActivity.attempt' is possibly 'null' or 'undefined'.
  • L287:13: 'activityTaskScheduled' is possibly 'undefined'.
src/lib/layouts/workflow-history-layout.svelte (2)
  • L225:2: Type 'string | undefined' is not assignable to type 'string'.
  • L226:2: Type 'string | undefined' is not assignable to type 'string'.
src/lib/layouts/workflow-timeline-layout.svelte (3)
  • L119:20: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L125:14: 'workflow' is possibly 'null'.
  • L126:9: 'workflow' is possibly 'null'.

Generated by 🚫 dangerJS against 7c5fde4

@laurakwhit laurakwhit force-pushed the add-back-event-history-legend branch from 39bd68b to 7c5fde4 Compare February 25, 2026 16:34
@laurakwhit laurakwhit changed the title Add back event history legend Add back event history legend and auto refresh Feb 25, 2026
Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thought is whether the refresh_off URL search param makes sense. I think it's better than frozen, but it might make the code easier to reason about if the param is flipped, eg. auto_refresh=true. Otherwise lgtm.

@laurakwhit laurakwhit merged commit 3940246 into main Feb 25, 2026
20 checks passed
@laurakwhit laurakwhit deleted the add-back-event-history-legend branch February 25, 2026 17:10
temporal-cicd bot pushed a commit that referenced this pull request Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0

Bump type: minor

Changes included:
- [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184)
- [`39402461`](3940246) Add back event history legend and auto refresh (#3187)
- [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188)
- [`0ee9b8e7`](0ee9b8e) encode activity id (#3191)
- [`dbe3114e`](dbe3114) Fix workflow errors (#3190)
- [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)
rossedfort added a commit that referenced this pull request Feb 25, 2026
Auto-generated version bump from 2.46.0 to 2.47.0

Bump type: minor

Changes included:
- [`948e5d53`](948e5d5) fix(workflow): remove max height from event history table and default to timeline (#3184)
- [`39402461`](3940246) Add back event history legend and auto refresh (#3187)
- [`d541be94`](d541be9) fix(workflow): restore input/result height and fix breadcrumb link (#3188)
- [`0ee9b8e7`](0ee9b8e) encode activity id (#3191)
- [`dbe3114e`](dbe3114) Fix workflow errors (#3190)
- [`e326c8d5`](e326c8d) Bump API to v1.62.2 (#3189)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants