Skip to content

Remove unused Set up Protoc step from workflows#3323

Merged
laurakwhit merged 1 commit intomainfrom
ci/remove-unused-setup-protoc
Apr 21, 2026
Merged

Remove unused Set up Protoc step from workflows#3323
laurakwhit merged 1 commit intomainfrom
ci/remove-unused-setup-protoc

Conversation

@laurakwhit
Copy link
Copy Markdown
Collaborator

@laurakwhit laurakwhit commented Apr 20, 2026

Description & motivation 💭

The arduino/setup-protoc step in playwright.yml and test.yml installed the protoc compiler, but nothing in CI actually used it:

  • server/Makefile's build target only runs go mod tidy + go build — no protoc invocation
  • No .pb.go files are generated or checked into this repo
  • The .proto sources under server/proto/dependencies/api/ have their own Makefile for regeneration, but that's a manual/separate process

Removing it also fixes the current breakage where arduino/setup-protoc@v3's floating tag resolution fails to fetch its tarball.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 20, 2026 4:34pm

Request Review

@laurakwhit laurakwhit force-pushed the ci/remove-unused-setup-protoc branch from 73e7007 to 02a31b5 Compare April 20, 2026 16:33
@laurakwhit laurakwhit marked this pull request as ready for review April 20, 2026 16:42
@laurakwhit laurakwhit requested a review from a team as a code owner April 20, 2026 16:42
@laurakwhit laurakwhit requested a review from rossnelson April 20, 2026 16:43
@laurakwhit laurakwhit merged commit 21f2d44 into main Apr 21, 2026
20 checks passed
@laurakwhit laurakwhit deleted the ci/remove-unused-setup-protoc branch April 21, 2026 22:50
rossedfort added a commit that referenced this pull request Apr 22, 2026
Auto-generated version bump from 2.48.4 to 2.49.0

Bump type: minor

Changes included:
- [`9146199f`](9146199) fix: ref main in reusable PR review workflows (#3326)
- [`ca904926`](ca90492) test(e2e): add end-to-end payload decoder coverage (#3321)
- [`4e32d230`](4e32d23) chore: add setup-worktree skill (#3278)
- [`a789fbdb`](a789fbd) Fix decoding payloads for user metadata (#3328)
- [`21f2d448`](21f2d44) ci: remove unused Set up Protoc step from workflows (#3323)
- [`39c41d25`](39c41d2) fix(ui): guard getApiOrigin against undefined VITE_API (#3332)
- [`627cbb1b`](627cbb1) feat: add showInstancesLink prop to deployment header (#3331)
- [`0726c65e`](0726c65) Check certFile modification time instead of keyFile (#3178)
- [`8c79931b`](8c79931) feat(DT-3887): remove Dispatch Rate Epsilon from compute scaling UI (#3334)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants