Skip to content

Fix decoding payloads for user metadata#3328

Merged
rossedfort merged 10 commits intomainfrom
fix-workflow-summary-decode
Apr 21, 2026
Merged

Fix decoding payloads for user metadata#3328
rossedfort merged 10 commits intomainfrom
fix-workflow-summary-decode

Conversation

@rossedfort
Copy link
Copy Markdown
Contributor

Description & motivation 💭

  • adds a base64 decode step to to the decodeUserMetadata call

Screenshots (if applicable) 📸

before

user metadata tab event history
Screenshot 2026-04-21 at 10 07 31 AM Screenshot 2026-04-21 at 10 07 22 AM

after

user metadata tab event history
Screenshot 2026-04-21 at 10 05 26 AM Screenshot 2026-04-21 at 10 05 08 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@rossedfort rossedfort requested a review from a team as a code owner April 21, 2026 16:10
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 21, 2026 8:07pm

Request Review

@@ -211,7 +211,7 @@ export const decodeUserMetadata = async (
try {
const data = await decodePayloadsWithRemoteCodec([payload]);
const result = data[0];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type 'unknown' is not assignable to parameter of type 'Payload'.

@temporal-cicd
Copy link
Copy Markdown
Contributor

temporal-cicd Bot commented Apr 21, 2026

Warnings
⚠️

📊 Strict Mode: 23 errors in 3 files (2.3% of 998 total)

src/lib/utilities/decode-payload.ts (21)
  • L80:45: Argument of type '{ [k: string]: string; } | undefined' is not assignable to parameter of type 'Record<string, unknown>'.
  • L93:45: Argument of type '{ [k: string]: string; } | undefined' is not assignable to parameter of type 'Record<string, unknown>'.
  • L127:19: No overload matches this call.
  • L128:6: 'searchAttributes' is of type 'unknown'.
  • L128:52: Argument of type 'unknown' is not assignable to parameter of type 'Payload'.
  • L136:19: No overload matches this call.
  • L137:6: 'memo' is of type 'unknown'.
  • L137:40: Argument of type 'unknown' is not assignable to parameter of type 'Payload'.
  • L145:19: No overload matches this call.
  • L146:6: 'header' is of type 'unknown'.
  • L146:42: Argument of type 'unknown' is not assignable to parameter of type 'Payload'.
  • L155:19: No overload matches this call.
  • L156:6: 'queryResult' is of type 'unknown'.
  • L156:47: Argument of type 'unknown' is not assignable to parameter of type 'Payload'.
  • L174:26: Argument of type 'unknown' is not assignable to parameter of type 'Payload'.
  • L213:33: Argument of type 'unknown' is not assignable to parameter of type 'Payload'.
  • L270:57: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ id: string; attributes: EventAttribute; timestamp: string; classification: "Scheduled" | "Unspecified" | "Open" | "New" | "Started" | "Initiated" | "Running" | ... 7 more ... | "CancelRequested"; ... 70 more ...; eventId: string; } | ... 62 more ... | { ...; }'.
  • L271:29: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ id: string; attributes: EventAttribute; timestamp: string; classification: "Scheduled" | "Unspecified" | "Open" | "New" | "Started" | "Initiated" | "Running" | ... 7 more ... | "CancelRequested"; ... 70 more ...; eventId: string; } | ... 62 more ... | { ...; }'.
  • L273:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ id: string; attributes: EventAttribute; timestamp: string; classification: "Scheduled" | "Unspecified" | "Open" | "New" | "Started" | "Initiated" | "Running" | ... 7 more ... | "CancelRequested"; ... 70 more ...; eventId: string; } | ... 62 more ... | { ...; }'.
  • L275:21: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ id: string; attributes: EventAttribute; timestamp: string; classification: "Scheduled" | "Unspecified" | "Open" | "New" | "Started" | "Initiated" | "Running" | ... 7 more ... | "CancelRequested"; ... 70 more ...; eventId: string; } | ... 62 more ... | { ...; }'.
  • L277:10: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ id: string; attributes: EventAttribute; timestamp: string; classification: "Scheduled" | "Unspecified" | "Open" | "New" | "Started" | "Initiated" | "Running" | ... 7 more ... | "CancelRequested"; ... 70 more ...; eventId: string; } | ... 62 more ... | { ...; }'.
src/lib/holocene/markdown-editor/preview.svelte (1)
  • L34:6: 'iframe.contentWindow' is possibly 'null'.
temporal/client.ts (1)
  • L37:3: Function lacks ending return statement and return type does not include 'undefined'.

Generated by 🚫 dangerJS against 1f7ca83

Comment thread temporal/client.ts
@rossedfort rossedfort merged commit a789fbd into main Apr 21, 2026
19 checks passed
@rossedfort rossedfort deleted the fix-workflow-summary-decode branch April 21, 2026 20:27
rossedfort added a commit that referenced this pull request Apr 22, 2026
Auto-generated version bump from 2.48.4 to 2.49.0

Bump type: minor

Changes included:
- [`9146199f`](9146199) fix: ref main in reusable PR review workflows (#3326)
- [`ca904926`](ca90492) test(e2e): add end-to-end payload decoder coverage (#3321)
- [`4e32d230`](4e32d23) chore: add setup-worktree skill (#3278)
- [`a789fbdb`](a789fbd) Fix decoding payloads for user metadata (#3328)
- [`21f2d448`](21f2d44) ci: remove unused Set up Protoc step from workflows (#3323)
- [`39c41d25`](39c41d2) fix(ui): guard getApiOrigin against undefined VITE_API (#3332)
- [`627cbb1b`](627cbb1) feat: add showInstancesLink prop to deployment header (#3331)
- [`0726c65e`](0726c65) Check certFile modification time instead of keyFile (#3178)
- [`8c79931b`](8c79931) feat(DT-3887): remove Dispatch Rate Epsilon from compute scaling UI (#3334)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants