Refactor status counts and refresh button by laurakwhit · Pull Request #3402 · temporalio/ui

laurakwhit · 2026-05-15T22:58:30Z

Description & motivation 💭

Swaps ActivityCountRefresh for the shared CountRefreshButton on standalone activities page
Adds formatted refresh time to the workers page header
Adjusts workers and workflows header spacing for the refresh button
Unifies WorkflowCounts and ActivityCounts into one StatusCounts component

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

Manual testing
E2E tests added
Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

…Activities page

vercel · 2026-05-15T22:58:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
holocene	Ready	Preview, Comment	May 18, 2026 10:13pm

temporal-cicd · 2026-05-15T22:59:45Z

	Warnings
⚠️	📊 Strict Mode: 19 errors in 1 file (2.1% of 913 total) src/lib/pages/schedule-view.svelte (19) L138:18: Property 'message' does not exist on type '{}'. L300:20: 'schedule.schedule' is possibly 'undefined'. L300:20: 'schedule.schedule.state' is possibly 'null' or 'undefined'. L400:12: Type 'IScheduleActionResult[] \| null \| undefined' is not assignable to type 'IScheduleActionResult[] \| undefined'. L404:12: Type 'ITimestamp[] \| null \| undefined' is not assignable to type 'ITimestamp[] \| undefined'. L407:12: Type 'IScheduleSpec \| null \| undefined' is not assignable to type 'IScheduleSpec'. L408:12: Type 'IScheduleState \| null \| undefined' is not assignable to type 'IScheduleState'. L409:12: Type 'ISchedulePolicies \| null \| undefined' is not assignable to type 'ISchedulePolicies'. L410:12: Type 'string \| null \| undefined' is not assignable to type 'string \| undefined'. L419:12: Type 'IPayloads \| null \| undefined' is not assignable to type 'IPayloads'. L421:34: Type 'IScheduleSpec \| null \| undefined' is not assignable to type 'IScheduleSpec'. L429:19: 'schedule.schedule' is possibly 'undefined'. L429:19: 'schedule.schedule.state' is possibly 'null' or 'undefined'. L438:9: 'schedule.schedule' is possibly 'undefined'. L438:9: 'schedule.schedule.state' is possibly 'null' or 'undefined'. L444:11: 'schedule.schedule' is possibly 'undefined'. L444:11: 'schedule.schedule.state' is possibly 'null' or 'undefined'. L453:11: 'schedule.schedule' is possibly 'undefined'. L453:11: 'schedule.schedule.state' is possibly 'null' or 'undefined'.

Generated by 🚫 dangerJS against dd1b3c8

rossedfort · 2026-05-18T20:00:17Z

    .map((group) => {
      const rawStatus = parseRawPayloadToJSON(
-        group?.groupValues[0],
+        (group?.groupValues as unknown as Payload[])[0],


What type is group.groupValues ? I would like to avoid type casting payload related stuff as it previously was done fairly frequently and caused a huge headache when refactoring the payload decoder code in preparation for supporting external payloads.

It was typed to Payloads, but updated the response to be Payload[] instead in dd1b3c8 ✅

rossedfort · 2026-05-18T20:06:28Z

+  );
+
+  $effect(() => {
+    void refreshTime;


Is this so that this effect will re-run when refreshTime changes?

Correct, we want to update the task failure counts on refresh similar to other status counts.

Auto-generated version bump from 2.49.1 to 2.50.0 Bump type: minor Changes included: - [`29832bec`](29832be) Use initiatedEvent for startChildFailed event grouping (#3342) - [`91a01560`](91a0156) rm slash (#3343) - [`2e7b88d0`](2e7b88d) feat: Set Current Version action for worker deployment versions (#3319) - [`b2685f3b`](b2685f3) Add relative path prefix support to routeFor utilities (#3292) - [`9c888c0c`](9c888c0) fix: validate connection modal status, retry button, and copy nits (#3347) - [`38989c48`](38989c4) revert: restore original create worker deployment copy (#3348) - [`90e1fe58`](90e1fe5) Common Errors for Event History (#3306) - [`f479e4e2`](f479e4e) Show current duration for pending timeline events (#3346) - [`65a7ff0d`](65a7ff0) Add refresh button to workers list view (#3349) - [`219cfee4`](219cfee) Fix null conditionals in search attribute filter (#3351) - [`08bd2f01`](08bd2f0) Add support for adding caller Namespace even if it's not in list of allowed Namespace options for Nexus endpoint (#3167) - [`d424a78a`](d424a78) refactor(DT-3906): Add knip (#3350) - [`e828b14f`](e828b14) Remove icon (#3357) - [`252a755c`](252a755) Add Java to list of support versions for worker heartbeats (#3362) - [`0f446c7a`](0f446c7) refactor(DT-3906): Simple Svelte 5 migrations (#3359) - [`63db5b72`](63db5b7) feat(DT-3657): Support shift click for bulk selection in workflow table (#3344) - [`389d57bf`](389d57b) Enable Svelte 5 runes on files not using legacy features (#3363) - [`f4b87e1d`](f4b87e1) Update components/workflow to Svelte 5 syntax (#3361) - [`3e2cce43`](3e2cce4) refactor(DT-3906): More Svelte 5 Migrations (trivial ones) (#3364) - [`15adcd73`](15adcd7) refactor(DT-3906): UI svelte 5 migrate components/events (#3365) - [`031fb867`](031fb86) refactor(DT-3906): Migrate stories to Svelte 5 syntax (#3366) - [`4eac9d2a`](4eac9d2) Scope group hover to tooltip component only (#3379) - [`eeace5c3`](eeace5c) chore: upgrade TypeScript to v6.0.3 (#3371) - [`cb80efdd`](cb80efd) refactor(DT-3906): More trivial migrations (#3367) - [`6cc395bf`](6cc395b) refactor(DT-3906): migrate holocene primitives + layout components to Svelte 5 runes (#3377) - [`40a029ea`](40a029e) refactor(DT-3906): UI Svelte 5 Migrations medium (#3368) - [`7dc29ba6`](7dc29ba) refactor(DT-3906): Delete unused Svelte 4 scaffolding (carved from #3370 - Part 1) (#3372) - [`34a8547e`](34a8547) refactor(DT-3906): Migrate workflow client-action modals to runes (carved from #3370 - Part 4) (#3375) - [`61090d7e`](61090d7) refactor(DT-3906): Migrate schedule view components to runes (carved from #3370 - Part 2) (#3373) - [`988e0479`](988e047) refactor(DT-3906): Migrate filter and input components to runes (carved from #3370 - Part 3) (#3374) - [`d8b78496`](d8b7849) refactor(DT-3906): Migrate workflows-summary table + relationships to runes (carved from #3370 - Part 5) (#3376) - [`ff86c004`](ff86c00) fix(DT-3968): Make Workflow Table Tooltips render in portal (#3383) - [`5e02642a`](5e02642) fix(DT-3967): Visibly toggle the view children button even with a parent has 0 (#3382) - [`1f2b1031`](1f2b103) Remove capability guard from Set Current Version menu item (#3386) - [`0d54dcb4`](0d54dcb) fix: portal maximizable to body to escape stacking context (#3385) - [`abf45438`](abf4543) chore(security): patch Dependabot alerts for axios, protobufjs, fast-uri, uuid, postcss, gomarkdown (#3388) - [`4500f5ea`](4500f5e) Upgrade GitHub actions (#3389) - [`4a8c0c5b`](4a8c0c5) fix(timeline): stabilize child workflow timeline width with scrollbar-gutter (#3329) - [`ead14c61`](ead14c6) Move Create Schedule button to header row (#3390) - [`e8638a2b`](e8638a2) Add top margin (#3392) - [`ef03dfce`](ef03dfc) refactor: replace PayloadDecoder and MetadataDecoder with unified Payload component (#3299) - [`89b9eafa`](89b9eaf) add loading state to payload code block (#3397) - [`ee3ae138`](ee3ae13) Update Schedules search attributes filter (#3396) - [`41fd4f1f`](41fd4f1) DT-3751 - download external payloads (#3345) - [`e4fee0b6`](e4fee0b) Fix codec server request URL (#3400) - [`966b3d0a`](966b3d0) Make input from schedule result actually a string and update tests (#3403) - [`48a014db`](48a014d) feat(history): show Nexus operation name in compact view (#3394) - [`9127c768`](9127c76) Refactor status counts and refresh button (#3402) - [`747ec109`](747ec10) Fix double loader button (#3407) - [`6ae961fc`](6ae961f) Payload rendering and error optimizations (#3401) - [`32c74a48`](32c74a4) add codec server error banner back to workflow layout (#3408) - [`f73c7ec9`](f73c7ec) Nxs operation/kt (#3406) - [`672bb04a`](672bb04) Bump Go 1.26.2→1.26.3, x/net v0.54.0, remove curl from runtime image (#3409) - [`1ee09fe3`](1ee09fe) chore(deps-dev): bump svelte from 5.55.1 to 5.55.7 (#3395) - [`565bb071`](565bb07) VLN-1352: remediate missing-dependency-cooldown (#3398) - [`25794ed8`](25794ed) Bump devalue to 5.8.1 (#3410) - [`b18d0060`](b18d006) Set color-scheme explicitly (#3358) - [`e7995b81`](e7995b8) chore: ensure the empty app.html respects the user's ligh/dark settings (#3353) - [`01d64038`](01d6403) fix: enable external payload download button with namespace level codec endpoint (#3420) - [`4cc44311`](4cc4431) Fix publicPath URL duplication when prefix appears as substring (#3393) Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>

laurakwhit added 4 commits May 15, 2026 10:33

Use CountRefreshButton instead of ActivityCountRefresh on Standalone …

a0a7692

…Activities page

Add formatted refresh time to workers page

25317db

Adjust workflows header spacing for refresh button

9bd91b8

Use StatusCounts component for both workflow and standalone activities

583f818

Fix strict errors

755a4e7

vercel Bot deployed to Preview May 18, 2026 19:39 View deployment

laurakwhit marked this pull request as ready for review May 18, 2026 19:54

laurakwhit requested a review from a team as a code owner May 18, 2026 19:54

laurakwhit requested a review from rossedfort May 18, 2026 19:57

rossedfort reviewed May 18, 2026

View reviewed changes

Fix groupValues type

dd1b3c8

vercel Bot deployed to Preview May 18, 2026 22:13 View deployment

laurakwhit requested a review from rossedfort May 18, 2026 22:14

rossedfort approved these changes May 18, 2026

View reviewed changes

laurakwhit merged commit 9127c76 into main May 18, 2026
22 checks passed

laurakwhit deleted the chore/unify-count-refresh-button branch May 18, 2026 22:43

temporal-cicd Bot mentioned this pull request May 21, 2026

chore: bump version to 2.50.0 #3421

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor status counts and refresh button#3402

Refactor status counts and refresh button#3402
laurakwhit merged 6 commits into
mainfrom
chore/unify-count-refresh-button

laurakwhit commented May 15, 2026

Uh oh!

vercel Bot commented May 15, 2026 •

edited

Loading

Uh oh!

temporal-cicd Bot commented May 15, 2026 •

edited

Loading

Uh oh!

rossedfort May 18, 2026

Uh oh!

laurakwhit May 18, 2026

Uh oh!

rossedfort May 18, 2026

Uh oh!

laurakwhit May 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

laurakwhit commented May 15, 2026

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Uh oh!

vercel Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

temporal-cicd Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rossedfort May 18, 2026

Choose a reason for hiding this comment

Uh oh!

laurakwhit May 18, 2026

Choose a reason for hiding this comment

Uh oh!

rossedfort May 18, 2026

Choose a reason for hiding this comment

Uh oh!

laurakwhit May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented May 15, 2026 •

edited

Loading

temporal-cicd Bot commented May 15, 2026 •

edited

Loading