Skip to content

schedules - Update default timeouts to match workflow defaults#3634

Merged
tegan-temporal merged 1 commit into
mainfrom
schedules-default-timeouts
Jul 6, 2026
Merged

schedules - Update default timeouts to match workflow defaults#3634
tegan-temporal merged 1 commit into
mainfrom
schedules-default-timeouts

Conversation

@tegan-temporal

Copy link
Copy Markdown
Contributor

Description & motivation 💭

With the implementaiton of the schedules redesign, the default timeouts were changed. Instead, we want to keep them matching the defaults for when you create a workflow.

Update default timeouts when creating a schedule to match the default workflow timeouts

Screenshots (if applicable) 📸

Screenshot 2026-07-06 at 2 51 17 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

https://temporalio.atlassian.net/browse/DT-4231

Docs

Any docs updates needed?

@tegan-temporal tegan-temporal self-assigned this Jul 6, 2026
@tegan-temporal tegan-temporal requested a review from a team as a code owner July 6, 2026 21:58
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jul 6, 2026 9:58pm

Request Review

);
});

it('omits run and execution timeouts when zeroed (no timeout)', async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Property 'startWorkflow' does not exist on type 'ScheduleActionRequest | undefined'.

action: { startWorkflow: { workflowRunTimeout: '300s' } },
},
} as unknown as DescribeFullSchedule;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Property 'startWorkflow' does not exist on type 'ScheduleActionRequest | undefined'.

@temporal-cicd

temporal-cicd Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 38 errors in 2 files (4.3% of 890 total)

src/lib/components/schedule/utilities/get-request-body.ts (5)
  • L36:47: Property 'action' does not exist on type '(ISchedule & Omit<ISchedule, "spec"> & { spec?: ScheduleSpecResponse | null | undefined; }) | undefined'.
  • L104:4: 'describeFullSchedule.schedule' is possibly 'undefined'.
  • L164:49: Property 'spec' does not exist on type '(ISchedule & Omit<ISchedule, "spec"> & { spec?: ScheduleSpecResponse | null | undefined; }) | undefined'.
  • L196:49: Property 'spec' does not exist on type '(ISchedule & Omit<ISchedule, "spec"> & { spec?: ScheduleSpecResponse | null | undefined; }) | undefined'.
  • L297:4: Type '{ indexedFields: { indexedFields?: { [k: string]: IPayload; } | null | undefined; }; } | null' is not assignable to type 'ISearchAttributes | null | undefined'.
src/lib/components/schedule/utilities/get-request-body.test.ts (33)
  • L28:11: 'body.schedule.action' is possibly 'undefined'.
  • L31:11: 'body.schedule.action' is possibly 'undefined'.
  • L34:11: 'body.schedule.action' is possibly 'undefined'.
  • L51:11: 'body.schedule.spec' is possibly 'undefined'.
  • L60:11: 'body.schedule.spec' is possibly 'undefined'.
  • L70:11: 'body.schedule.spec' is possibly 'undefined'.
  • L84:11: 'body.schedule.spec' is possibly 'undefined'.
  • L85:11: 'body.schedule.spec' is possibly 'undefined'.
  • L85:11: 'body.schedule.spec.structuredCalendar' is possibly 'null' or 'undefined'.
  • L93:11: 'body.schedule.spec' is possibly 'undefined'.
  • L94:11: 'body.schedule.spec' is possibly 'undefined'.
  • L99:11: 'body.schedule.spec' is possibly 'undefined'.
  • L107:11: 'body.schedule.spec' is possibly 'undefined'.
  • L115:11: 'body.schedule.state' is possibly 'undefined'.
  • L116:11: 'body.schedule.state' is possibly 'undefined'.
  • L122:11: 'body.schedule.state' is possibly 'undefined'.
  • L123:11: 'body.schedule.state' is possibly 'undefined'.
  • L128:11: 'withJitter.schedule.spec' is possibly 'undefined'.
  • L131:11: 'withoutJitter.schedule.spec' is possibly 'undefined'.
  • L139:11: 'body.schedule.policies' is possibly 'undefined'.
  • L140:11: 'body.schedule.action' is possibly 'undefined'.
  • L146:12: Property 'startWorkflow' does not exist on type 'ScheduleActionRequest | undefined'.
  • L161:12: Property 'startWorkflow' does not exist on type 'ScheduleActionRequest | undefined'.
  • L176:11: 'body.schedule.policies' is possibly 'undefined'.
  • L177:11: 'body.schedule.policies' is possibly 'undefined'.
  • L182:11: 'body.schedule.state' is possibly 'undefined'.
  • L201:13: 'body.schedule.spec' is possibly 'undefined'.
  • L204:13: 'body.schedule.spec' is possibly 'undefined'.
  • L213:13: 'body.schedule.spec' is possibly 'undefined'.
  • L222:13: 'body.schedule.spec' is possibly 'undefined'.
  • L232:13: 'body.schedule.spec' is possibly 'undefined'.
  • L241:13: 'body.schedule.spec' is possibly 'undefined'.
  • L250:13: 'body.schedule.spec' is possibly 'undefined'.

Generated by 🚫 dangerJS against 7b0b96c

@tegan-temporal tegan-temporal enabled auto-merge (squash) July 6, 2026 22:05
@tegan-temporal tegan-temporal merged commit 7ac3719 into main Jul 6, 2026
22 checks passed
@tegan-temporal tegan-temporal deleted the schedules-default-timeouts branch July 6, 2026 22:07
tegan-temporal added a commit that referenced this pull request Jul 7, 2026
* Default Run/Execution timeouts to empty instead of 0s

Design follow-up to #3634: show truly empty Run and Execution timeout
inputs rather than 0s. Empty and 0s are server-equivalent (both mean the
server default / unlimited), and getRequestBody already omits zero/empty
values, so the request is unchanged.

- Default the constants to '' and allow empty in the form schema
- Seed empty when unset and normalize a stored 0s to empty on edit
- Drop the snap-to-default onblur on the run/execution inputs

* Show 'No timeout' in schedule summary for empty run/execution timeouts
temporal-cicd Bot pushed a commit that referenced this pull request Jul 8, 2026
Auto-generated version bump from 2.51.1 to 2.52.0

Bump type: minor

Changes included:
- [`9c6fcd54`](9c6fcd5) Add direct SSO redirect and backend logout (#3590)
- [`feab0d90`](feab0d9) a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics (#3560)
- [`d7bbfb01`](d7bbfb0) a11y(2.5.8): toast — replace bare close button with IconButton (36×36 px) (#3553)
- [`4efd6ab6`](4efd6ab) a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement (#3554)
- [`0600b700`](0600b70) Use green only (#3599)
- [`94107549`](9410754) Clarify activity pause timeout behavior (#3600)
- [`9f88d5a8`](9f88d5a) Bump node version to 22.23.1 or newer to fix issue from previous security release (#3604)
- [`ca4104ae`](ca4104a) Update reason copy and inputs (#3588)
- [`51db73fa`](51db73f) Update batch operation reason input hint (#3605)
- [`836d7c55`](836d7c5) a11y(2.4.3): route navigation — move focus to the main landmark on afterNavigate, not just scroll (#3538)
- [`4ee95696`](4ee9569) Improve re-renders for large encoded event histories (#3592)
- [`fa5e7aa1`](fa5e7aa) feature/schedules (#3603)
- [`0d9467fd`](0d9467f) Default includeHeartbeatDetails and includeLastFailure to true for getActivityExecution and pollActivityExecution (#3521)
- [`e5bc514e`](e5bc514) fix schedules: duplicate key (#3612)
- [`f1eb489f`](f1eb489) Remove preview badge (#3581)
- [`1e5173b4`](1e5173b) Add existing versions to worker create deployment version form (#3601)
- [`a8552bae`](a8552ba) fix schedules -e.trim not a function (#3613)
- [`0442f847`](0442f84) Fix width of ComputeBadge in VersionTableRow (#3615)
- [`ddbeb54f`](ddbeb54) fix(cloud-nav): animate and stabilize side-nav collapse (#3606)
- [`3cfc684b`](3cfc684) fix - schedules recent/upcoming runs - sort issue (#3616)
- [`92b8875b`](92b8875) Move timestamp out of translate (#3617)
- [`901258af`](901258a) Fix SAA and WF consistency (#3614)
- [`99593d97`](99593d9) DT-4001 - standalone nexus operations (#3496)
- [`f10d1bf1`](f10d1bf) Clamp codeblock to container width (#3621)
- [`0a9d93ce`](0a9d93c) Remove unnecessary bottom-0 (#3623)
- [`9dabb522`](9dabb52) chore(deps-dev): bump vite from 6.4.2 to 6.4.3 (#3610)
- [`5c1854d3`](5c1854d) News Feed (#3596)
- [`340da30f`](340da30) a11y(2.1.1): guard global r/R keydown so text inputs can receive the letter (#3589)
- [`dd97a9d1`](dd97a9d) fix(markdown-editor): disable chromatic snapshot for preview story (#3631)
- [`7db61ab9`](7db61ab) a11y(4.1.2): Table / ProgressBar / Loading primitives — expose aria-busy on data-refresh regions (#3555)
- [`d2111ecf`](d2111ec) a11y(4.1.3): Add live-region wrappers for workflow status, event count, filter counts, and Banner (#3561)
- [`24eabaec`](24eabae) a11y(2.4.6): guard DrawerContent against empty <h2> when title is omitted (#3595)
- [`3552e307`](3552e30) Fix CodeMirror Lezer dependency mismatch (#3632)
- [`7ac37199`](7ac3719) Update defaults to match workflow defaults (#3634)
- [`c1f02865`](c1f0286) Draft fix for link variant handling (#3620)
- [`bbbf2b8c`](bbbf2b8) Add connection status and optional Latest Version column to deployments (DT-4174) (#3618)
- [`76f266f4`](76f266f) DurationInput updates (#3633)
- [`07da53c5`](07da53c) COM-191 - prefill CloudFormation template params in Launch Stack link (#3619)
- [`90946e0b`](90946e0) Schedules - Timeout empty defaults (#3637)
- [`97f9ad39`](97f9ad3) fix(cloud-nav): smooth label fade on side-nav collapse/expand (#3628)
- [`a399ed35`](a399ed3) Improve Search Attribute deletion messaging (#3629)
- [`ad976d94`](ad976d9) Pass through source prop for News Feed Widget (#3638)
- [`6ef84fe3`](6ef84fe) Restrict select-all to exclude workflow status (#3639)
- [`4c3729f8`](4c3729f) Reduce news feed markdown whitespace (#3642)
- [`aa04a9b6`](aa04a9b) feat(nexus-operations): add loading state to standalone nexus operations list page header (#3643)
- [`dce2f804`](dce2f80) chore: remove unused generate-holocene-props script (#3644)
- [`760bc7bc`](760bc7b) Make megaphone icon bigger (#3645)
- [`c047384a`](c047384) refactor(nexus): replace hand-rolled types with @temporalio/proto (#3646)
rossedfort added a commit that referenced this pull request Jul 8, 2026
Auto-generated version bump from 2.51.1 to 2.52.0

Bump type: minor

Changes included:
- [`9c6fcd54`](9c6fcd5) Add direct SSO redirect and backend logout (#3590)
- [`feab0d90`](feab0d9) a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics (#3560)
- [`d7bbfb01`](d7bbfb0) a11y(2.5.8): toast — replace bare close button with IconButton (36×36 px) (#3553)
- [`4efd6ab6`](4efd6ab) a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement (#3554)
- [`0600b700`](0600b70) Use green only (#3599)
- [`94107549`](9410754) Clarify activity pause timeout behavior (#3600)
- [`9f88d5a8`](9f88d5a) Bump node version to 22.23.1 or newer to fix issue from previous security release (#3604)
- [`ca4104ae`](ca4104a) Update reason copy and inputs (#3588)
- [`51db73fa`](51db73f) Update batch operation reason input hint (#3605)
- [`836d7c55`](836d7c5) a11y(2.4.3): route navigation — move focus to the main landmark on afterNavigate, not just scroll (#3538)
- [`4ee95696`](4ee9569) Improve re-renders for large encoded event histories (#3592)
- [`fa5e7aa1`](fa5e7aa) feature/schedules (#3603)
- [`0d9467fd`](0d9467f) Default includeHeartbeatDetails and includeLastFailure to true for getActivityExecution and pollActivityExecution (#3521)
- [`e5bc514e`](e5bc514) fix schedules: duplicate key (#3612)
- [`f1eb489f`](f1eb489) Remove preview badge (#3581)
- [`1e5173b4`](1e5173b) Add existing versions to worker create deployment version form (#3601)
- [`a8552bae`](a8552ba) fix schedules -e.trim not a function (#3613)
- [`0442f847`](0442f84) Fix width of ComputeBadge in VersionTableRow (#3615)
- [`ddbeb54f`](ddbeb54) fix(cloud-nav): animate and stabilize side-nav collapse (#3606)
- [`3cfc684b`](3cfc684) fix - schedules recent/upcoming runs - sort issue (#3616)
- [`92b8875b`](92b8875) Move timestamp out of translate (#3617)
- [`901258af`](901258a) Fix SAA and WF consistency (#3614)
- [`99593d97`](99593d9) DT-4001 - standalone nexus operations (#3496)
- [`f10d1bf1`](f10d1bf) Clamp codeblock to container width (#3621)
- [`0a9d93ce`](0a9d93c) Remove unnecessary bottom-0 (#3623)
- [`9dabb522`](9dabb52) chore(deps-dev): bump vite from 6.4.2 to 6.4.3 (#3610)
- [`5c1854d3`](5c1854d) News Feed (#3596)
- [`340da30f`](340da30) a11y(2.1.1): guard global r/R keydown so text inputs can receive the letter (#3589)
- [`dd97a9d1`](dd97a9d) fix(markdown-editor): disable chromatic snapshot for preview story (#3631)
- [`7db61ab9`](7db61ab) a11y(4.1.2): Table / ProgressBar / Loading primitives — expose aria-busy on data-refresh regions (#3555)
- [`d2111ecf`](d2111ec) a11y(4.1.3): Add live-region wrappers for workflow status, event count, filter counts, and Banner (#3561)
- [`24eabaec`](24eabae) a11y(2.4.6): guard DrawerContent against empty <h2> when title is omitted (#3595)
- [`3552e307`](3552e30) Fix CodeMirror Lezer dependency mismatch (#3632)
- [`7ac37199`](7ac3719) Update defaults to match workflow defaults (#3634)
- [`c1f02865`](c1f0286) Draft fix for link variant handling (#3620)
- [`bbbf2b8c`](bbbf2b8) Add connection status and optional Latest Version column to deployments (DT-4174) (#3618)
- [`76f266f4`](76f266f) DurationInput updates (#3633)
- [`07da53c5`](07da53c) COM-191 - prefill CloudFormation template params in Launch Stack link (#3619)
- [`90946e0b`](90946e0) Schedules - Timeout empty defaults (#3637)
- [`97f9ad39`](97f9ad3) fix(cloud-nav): smooth label fade on side-nav collapse/expand (#3628)
- [`a399ed35`](a399ed3) Improve Search Attribute deletion messaging (#3629)
- [`ad976d94`](ad976d9) Pass through source prop for News Feed Widget (#3638)
- [`6ef84fe3`](6ef84fe) Restrict select-all to exclude workflow status (#3639)
- [`4c3729f8`](4c3729f) Reduce news feed markdown whitespace (#3642)
- [`aa04a9b6`](aa04a9b) feat(nexus-operations): add loading state to standalone nexus operations list page header (#3643)
- [`dce2f804`](dce2f80) chore: remove unused generate-holocene-props script (#3644)
- [`760bc7bc`](760bc7b) Make megaphone icon bigger (#3645)
- [`c047384a`](c047384) refactor(nexus): replace hand-rolled types with @temporalio/proto (#3646)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants