feat: add MPPX integration carousel - #819
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9743be53db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| app.get( | ||
| '/premium', | ||
| mppx.charge({ amount: '1' }), |
There was a problem hiding this comment.
The carousel presents these as complete integrations, but every route passes only amount. Tempo also needs a currency and recipient—either in tempo.charge(...) or the request—while Stripe requires currency and decimals; as written, the first slide can't create the advertised USDC.e Challenge, and the Stripe and multi-method slides are similarly unusable when copied. Add realistic per-method configuration matching the server reference examples.
AGENTS.md reference: AGENTS.md:L291-L291
Useful? React with 👍 / 👎.
| ); | ||
|
|
||
| useEffect(() => { | ||
| if (prefersReducedMotion) return; |
There was a problem hiding this comment.
When the visitor enables prefers-reduced-motion, this early return permanently leaves activeIndex at zero. Because the only indicators are aria-hidden spans rather than controls, those visitors have no way to view the Stripe, Bitcoin, or multi-method examples; disable autoplay for reduced motion, but provide operable slide controls.
Useful? React with 👍 / 👎.
| <div className="marketing-single-line-intro"> | ||
| <SectionLabel>Integrate</SectionLabel> | ||
| <h2>Sell to agents with just a single line of code</h2> | ||
| <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p> |
There was a problem hiding this comment.
The new landing-page section renders this lorem ipsum sentence verbatim for every visitor, leaving its primary explanatory copy unfinished and providing no context for the carousel. Replace it with final copy that describes the MPPX integration benefit.
Useful? React with 👍 / 👎.
| const TYPESCRIPT_HIGHLIGHTER = Promise.all([ | ||
| import("shiki/core"), | ||
| import("shiki/engine/javascript"), | ||
| import("shiki/dist/langs/typescript.mjs"), | ||
| import("shiki/dist/themes/github-dark-default.mjs"), |
There was a problem hiding this comment.
This module-level promise starts fetching Shiki core, its regex engine, the TypeScript grammar, and the theme as soon as the landing-page component evaluates, even though the carousel sits below the hero, terminal, and integrations sections. On slow connections these non-critical highlighting chunks compete with above-the-fold resources for every visitor; initialize the highlighter when the section approaches the viewport or pre-render the four static snippets.
Useful? React with 👍 / 👎.
54144a4 to
68fe75f
Compare
5978b5a to
7ba0f13
Compare
1 participant
Motivation
Make payment-method setup immediately discoverable from the landing page.
Summary
Key design considerations