Skip to content

feat(notifications): NotificationCoordinator skeleton + type registry#342

Merged
tempus2016 merged 4 commits into
mainfrom
feat/notifications-overhaul
May 10, 2026
Merged

feat(notifications): NotificationCoordinator skeleton + type registry#342
tempus2016 merged 4 commits into
mainfrom
feat/notifications-overhaul

Conversation

@tempus2016

Copy link
Copy Markdown
Owner

Summary

  • Adds 6 notification type ID constants to const.py (Task 4, Step 1)
  • Creates coord_notifications.py with NotificationCoordinator, NOTIFICATION_TYPES registry, _SafeDict template renderer, and full fire() dispatch pipeline
  • Wires NotificationCoordinator into TaskMateCoordinator.__init__ as self.notifications
  • 5 smoke tests covering: master-disabled skip, per-recipient enable/disable routing, safe template rendering with missing keys, bus event emission with recipients list, unknown-type logging

Test plan

  • pytest tests/test_notifications_dispatch.py -v — 5/5 pass
  • Full suite pytest -q — 417 passed, 0 failures
  • Only 4 files changed: const.py, coord_notifications.py, coordinator.py, tests/test_notifications_dispatch.py

@tempus2016 tempus2016 merged commit ff6d530 into main May 10, 2026
2 checks passed
@tempus2016 tempus2016 deleted the feat/notifications-overhaul branch May 10, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant