feat(notifications): unified notification system v3.9.0#344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces TaskMate's narrow notification surface (single global
notify_service+ per-badgenotify_on_earn) with a unified per-event, multi-recipient configuration page in the admin panel.Four new notification types (all opt-in, default OFF):
Approve/Rejectaction buttons (tap-to-approve from the notification banner)Custom scheduled notifications — parents can define their own timed reminders with name, message template (
{child_name}placeholder), time, day-of-week mask, and recipient list.Power-user
taskmate_*event bus — every state change emits a clean event for Node-RED / HA automations:taskmate_chore_completed,taskmate_chore_approvedtaskmate_streak_updated,taskmate_perfect_weektaskmate_reward_claimedtaskmate_badge_earned(was already there; documented now)taskmate_<type_id>events with recipient listNew admin tab "Notifications" with three sections:
Architecture
New
coord_notifications.py(NotificationCoordinator) is the single dispatcher for every notification. Other coords (coord_chores,coord_rewards,coord_points,coord_badges) stop building messages directly and callawait self.notifications.fire(type_id, context). The dispatcher handles routing, message templating (with_SafeDictso missing keys don't raise),persistent_notification, per-recipientnotify.*calls, mobile actionable data, and bus event emission.10 new WebSocket commands under
taskmate/notifications/*for the panel. Full migration on first load preserves existing behaviour: pending approvals, reward claims and badge earned default ON for the seeded parent recipient (migrated from legacynotify_servicesetting); the four new types default OFF.Test plan
notify_serviceis migrated into a parent recipient row (no surprise behaviour)taskmate_chore_completed→ complete a chore → event payload visibleMigration / backwards compatibility
notify_servicesetting is preserved (not deleted) — readable for rollbacknotify_on_earnflag still honoured (extra layer above the new master toggle)Fixes #N/A (no specific issue — direction set in chat session 2026-05-10)
Spec:
docs/superpowers/specs/2026-05-10-notifications-overhaul-design.md(local)Wireframe:
.tmp/notifications-wireframe.html(local)Plan:
docs/superpowers/plans/2026-05-10-notifications-overhaul.md(local)