fix(i18n): localize Child Badges sensor unit_of_measurement#349
Merged
Conversation
Same anti-pattern as #346: ChildBadgesSensor.native_unit_of_measurement was hardcoded to "badges". Move it to per-language entity translations. - Add `_attr_translation_key = "child_badges"` and drop the hardcoded `native_unit_of_measurement` property. - Add `entity.sensor.child_badges.unit_of_measurement` to all 8 locale files (en, en-GB, de, fr, nb, nn, pt, pt-BR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #347. Same anti-pattern:
ChildBadgesSensor.native_unit_of_measurementwas hardcoded to"badges". Replaced with_attr_translation_key = "child_badges"and entity translations in all 8 locale files.Translations
Test plan
sensor.taskmate_<child>_badgesshowsAbzeichenasunit_of_measurement.medalhas.badges.Related: #348 (broader entity-name localization tracker).