fix(panel): add up/down buttons to chore reorder dialog#385
Merged
Conversation
The admin panel's Chore Order dialog (Manage > Children > Chore Order and the global chore reorder) relied solely on native HTML5 drag-and-drop. Native DnD never fires on touchscreens, so reordering was impossible on phones/tablets and was the only available method on desktop. Add up/down arrow buttons to each reorder row — the same reliable, accessible, cross-device pattern already used in taskmate-reorder-card.js. Existing drag-and-drop is unchanged for desktop. Reuses the existing reorder.move_up / reorder.move_down translation keys (present in all locales). Fixes #383
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The admin panel's Chore Order dialog (Manage → Children → Chore Order, and the global chore reorder) only supported native HTML5 drag-and-drop. Native DnD never fires on touchscreens, so reordering was completely broken on phones/tablets — and drag was the only method even on desktop.
Fix
Added up/down arrow buttons to each reorder row — the same reliable, accessible, cross-device pattern already shipping in
taskmate-reorder-card.js. The buttons work on mouse, touch, and keyboard. Existing drag-and-drop is left untouched for desktop users.reorder.move_up/reorder.move_downtranslation keys (already present in every locale) — no new strings.Testing
node --checkclean; click wiring mirrors the panel's existingdata-actdelegation.Fixes #383