fix(points-card): track and clear toast auto-hide timer (ERR-4)#587
Merged
Conversation
The 3s notification dismiss timer had no stored handle and was never cleared, so removing the card within 3s fired requestUpdate() on a detached element, and rapid actions stacked untracked timers (an older one could clear a newer toast early). Store the handle, clear it on re-trigger and in disconnectedCallback. Verified on ha-dev via browserless: timer is set on toast, cleared on disconnect, zero console errors past the 3s window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERR-4 — points-card toast
setTimeoutleakThe 3s notification auto-hide timer had no stored handle and was never cleared, so removing the card within 3s fired
requestUpdate()on a detached element, and rapid actions stacked untracked timers (an older one could clear a newer toast early). The handle is now stored, cleared on re-trigger and indisconnectedCallback.Testing
Verified on ha-dev via browserless: the timer is set when a toast shows, cleared on disconnect, and there are zero console errors past the 3s window.
From AUDIT_REPORT.md §3.2.