chore: remove dead code + correct set_setting typing (ERR-9, dead code)#598
Merged
Conversation
- storage.get_setting/set_setting were typed str despite storing bools/numbers/lists (the source of float-as-string round-tripping); annotate as Any. - rewards-card: drop dead .reward-row.dynamic/.dynamic-cost/.dynamic-indicator CSS (dynamic/surge pricing was deliberately removed). - child-card: remove unused tomorrowUTC local in _getMidnightCountdown. Verified: storage tests pass; both cards register on ha-dev with no console errors.
github-actions
Bot
added
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead code + typing cleanup (ERR-9, §3.3)
storage.get_setting/set_settingwere annotatedstrdespite storing bools/numbers/lists (the root of float-as-string round-tripping). Annotated asAny.rewards-card: removed dead.reward-row.dynamic/.cost-badge.dynamic-cost/.dynamic-indicatorCSS — dynamic/surge pricing was deliberately removed long ago.child-card: removed the unusedtomorrowUTClocal in_getMidnightCountdown.Testing
pytest tests/test_storage.py→ 40 passed; both cards register on ha-dev via browserless with zero console errors.From AUDIT_REPORT.md §3.2 / §3.3.