fix(rewards): grow card to fit all rewards in designed styles (#604)#615
Merged
Conversation
Designed styles (playroom/console/cleanpro) capped the reward list at a fixed 360px scroll region, which looked truncated when a card had more rewards than fit. Classic style already grows to fit. Make the list fluid by default and add an 'expand_to_fit' card option (default true). Set it to false to keep the fixed-height scrolling list.
github-actions
Bot
added
cards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604.
Problem
In the designed card styles (playroom / console / cleanpro) the rewards list was capped at a fixed
360pxscroll region (.rw-list { max-height: 360px; overflow-y: auto }). With more rewards than fit, the card looked truncated/cut off. The Classic style had no cap and grew to fit.Change
.rw-listis now fluid by default — it grows to show every reward, matching Classic.expand_to_fit(defaulttrue). Set tofalseto restore the fixed-height scrolling list.Only the designed styles are affected; Classic already grew to fit, so the option is a no-op there.
Testing
node -csyntax check passes; all locale JSON parses.pytest tests/test_card_design_setting.py tests/test_frontend_retired_cards.py→ 11 passed.