Skip to content

Conversation

@bitekas
Copy link

@bitekas bitekas commented Dec 23, 2020

Replacing the magic string constant with the canonical class name.
The previous format would cause incorrect code to compile but fail at runtime. The updated version checks the syntax on the compilation phase.
The exact class string code is an implementation detail and may change in the future making the example invalid.

@bitekas bitekas requested a review from MarkDaoust as a code owner December 23, 2020 03:51
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Dec 23, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented Dec 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA has not been signed label Dec 23, 2020
@bitekas
Copy link
Author

bitekas commented Dec 23, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Dec 23, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@bitekas bitekas force-pushed the viktor/l02c01-fixing-the-loss-syntax branch from 424c7d5 to 192ab45 Compare December 23, 2020 04:50
@google-cla google-cla bot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Dec 23, 2020
@bitekas
Copy link
Author

bitekas commented Mar 15, 2023

@googlebot I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA has been signed size:XS CL Change Size: Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant