This repository was archived by the owner on Mar 11, 2021. It is now read-only.
add handicap support to minigui #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
see warnings in docstring: |
Contributor
Author
|
@brilee right now, our sgf parser literally ignores any SGF property on a node that isn't B[] or W[]. the HA property requires that another property be set on the node ('AB') specifying the actual location of the handicap stones. So yeah your warning in the docstring is understood :) This PR doesn't add support for positions with existing stones, it just adjusts the semantics of our translation from "SGF Tree" => "Minigo Tree" |
Contributor
Author
|
fixes #845 |
tommadams
reviewed
Jul 3, 2019
Contributor
tommadams
left a comment
tommadams
left a comment
There was a problem hiding this comment.
Thanks for fixing my deficiencies!
tommadams
approved these changes
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick recap: as we walk the AST, we transform it into Sgf::Node with our own Move structs, etc.
This CL changes "GetTreeImpl" to look for a HA property, and if so, it adds Nodes for black to play handicap stones and white to pass.
The resulting tree of nodes is handled as before: the engine calls PlayMove on each.