Skip to content

Move the RemoveEdge() call outside the loop to avoid crash in debug builds #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2019
Merged

Move the RemoveEdge() call outside the loop to avoid crash in debug builds #143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae034c4
Move the RemoveEdge() call outside the loop in which it access the sa…
aaroey Jul 17, 2019
3b570d3
Merge branch 'master' into fix_remove_edge
avijit-nervana Jul 18, 2019
c851547
Merge branch 'master' into fix_remove_edge
avijit-nervana Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ngraph_capture_variables.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,16 @@ Status CaptureVariables(Graph* graph, const std::set<string> skip_these_nodes) {
NGRAPH_VLOG(4) << "Replacing Node " << node->DebugString() << " with "
<< replacement->DebugString();

// Though edges will be removed when we remove the node
// we specifically remove the edges to be sure
std::vector<const Edge*> edges_to_remove;
for (auto edge : node->in_edges()) {
NGRAPH_VLOG(4) << "Replacing: " << edge->DebugString();
graph->AddEdge(edge->src(), edge->src_output(), replacement,
edge->dst_input());
edges_to_remove.push_back(edge);
}
// Though edges will be removed when we remove the node
// we specifically remove the edges to be sure
for (auto edge : edges_to_remove) {
graph->RemoveEdge(edge);
}

Expand Down