Move the RemoveEdge() call outside the loop to avoid crash in debug builds #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me edge set, to avoid TF crash in graph.cc https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/graph/edgeset.h#L117
shresthamalik
approved these changes
Jul 17, 2019
Contributor
shresthamalik
left a comment
shresthamalik
left a comment
There was a problem hiding this comment.
LGTM. There are other places we do something similar. We can take an action items to correct those.
Contributor
@shresthamalik: These need change: These ones are done right: ngraph-bridge/src/ngraph_capture_variables.cc Line 103 in 6a542fb |
avijit-nervana
approved these changes
Jul 18, 2019
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
…me edge set, to avoid TF crash in graph.cc https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/graph/edgeset.h#L117 (#143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF disallows modifying the edgeset when iterating it, see:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/graph/edgeset.h#L117