Skip to content

Conversation

@vishakha-nervana
Copy link
Contributor

@vishakha-nervana vishakha-nervana commented Jul 31, 2019

This PR is bug fix reported by Guangda in this PR: #143
Tensor Flow EdgeSet data structure, does not allow updating the EdgeSet, while iterating,
so graph->Remove Edge(edge) was called in a separate loop.

@avijit-nervana
Copy link
Contributor

@vishakha-nervana Please provide some description about this PR.

@sayantan-nervana sayantan-nervana changed the title Fixed RemoveEdege() during the list iteration issue. Vishakha/Fixed RemoveEdege() during the list iteration issue. Aug 23, 2019
Copy link
Contributor

@sayantan-nervana sayantan-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shresthamalik shresthamalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sayantan-nervana sayantan-nervana merged commit 85c1b83 into master Sep 9, 2019
@sayantan-nervana sayantan-nervana deleted the vishakha/RemoveEdge branch September 9, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants