Kanvi/bazel build with clang libc++ #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove tbb.build file
This will need to be updated again once there is release
| RUN cmake --version | ||
|
|
||
| #Install Bazel | ||
| ADD https://github.com/bazelbuild/bazel/releases/download/0.24.1/bazel-0.24.1-installer-linux-x86_64.sh ./bazel-0.24.1-installer-linux-x86_64.sh |
Contributor
There was a problem hiding this comment.
Please update this wiki: https://github.com/tensorflow/ngraph-bridge/wiki/Update-TF-version-in-ngraph-bridge
when TF version is upgraded, bazel version will upgrade, and we need to upgrade this (and maybe other) docker file from 0.24.1 to next bazel version
sayantan-nervana
approved these changes
Sep 25, 2019
avijit-nervana
suggested changes
Sep 25, 2019
bazel/WORKSPACE
Outdated
| sha256 = "b33f0be032ff59044987ff796b636c1b222579705ac29632bba59b6031b0d58c", | ||
| strip_prefix = "ngraph-0.25.1-rc.3", | ||
| sha256 = "2437295ae696cee472231c38149cfa7cc46b6266c101ef76693e4519cb0604d7", | ||
| strip_prefix = "ngraph-0.25.1-rc.5", |
Contributor
There was a problem hiding this comment.
nGraph needs to be in the latest version i.e., rc7
| # Docker file to setup build envrionment for nGraph-TensorFlow | ||
|
|
||
| FROM ubuntu:18.04 | ||
| ENV http_proxy 'http://proxy-chain.intel.com:911' |
Contributor
There was a problem hiding this comment.
Remove these two lines. Update the instructions with information from here: #212 (comment)
bazel/ngraph.BUILD
Outdated
| '-D SHARED_LIB_PREFIX=\\"lib\\"', | ||
| '-D SHARED_LIB_SUFFIX=\\".so\\"', | ||
| '-D NGRAPH_VERSION=\\"v0.25.1-rc.3\\"', | ||
| '-D NGRAPH_VERSION=\\"v0.25.1-rc.5\\"', |
avijit-nervana
approved these changes
Sep 26, 2019
sayantan-nervana
pushed a commit
that referenced
this pull request
Sep 27, 2019
avijit-nervana
pushed a commit
that referenced
this pull request
Sep 27, 2019
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build the
hello_tfexample withclangandlibc++, this PR introduces a dockerfile which creates an env for the same. Thehello_tfexample cpp app is then built using the following command :BAZEL_LINKOPTS=-lc++ BAZEL_CXXOPTS=-stdlib=libc++ bazel build :hello_tfThe
READMEfor the dockerfile gives the detail steps to be followed.