sindhu/register backends #392
Conversation
| // Map with all the backends, and what the boolean is_supported should be | ||
| std::map<std::string, bool> backend_map{ | ||
| {"CPU", true}, {"INTERPRETER", true}, {"NOP", false}}; | ||
| std::map<std::string, bool> backend_map{{"CPU", true}, {"INTERPRETER", true}}; |
There was a problem hiding this comment.
removed NOP case here because we do not have static library available for this backend, so we cannot register NOP with static builds - so this test will fail.
sindhu-nervana
requested review from
kanvi-nervana,
sayantan-nervana and
shresthamalik
test/test_ngraph_exec.cpp
Outdated
| #include "ngraph_bridge/ngraph_builder.h" | ||
| #include "ngraph_bridge/ngraph_pipelined_tensors.h" | ||
| #include "ngraph_bridge/ngraph_utils.h" | ||
| #include "ngraph_bridge/version.h" |
There was a problem hiding this comment.
this is not required anymore
| return -1; | ||
| } | ||
|
|
||
| // Register backends for static linking |
There was a problem hiding this comment.
| // Register backends for static linking | |
| // Register cpu backend for static linking |
| return -1; | ||
| } | ||
|
|
||
| // Register backends for static linking |
There was a problem hiding this comment.
| // Register backends for static linking | |
| // Register cpu backend for static linking |
- Enabled --var build to use parallel executor integrating weights-on-device and data pipelining - moved ngraph_var files outside the var build
| #if defined(NGRAPH_BRIDGE_STATIC_LIB_ENABLE) | ||
| ngraph_register_cpu_backend(); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Right now we create only CPU backend here, hence the ifdef is only for CPU. But suggestions for future is we can query the backend we are trying to set/create and register just that backend if NGRAPH_BRIDGE_STATIC_LIB_ENABLE is enabled
| return -1; | ||
| } | ||
|
|
||
| // Register cpu backend for static linking |
There was a problem hiding this comment.
do we need to register here, since we have a registration in create backend?
There was a problem hiding this comment.
yeah it was failing otherwise because we are using set backend here
There was a problem hiding this comment.
TODO: Revisit this to see if we can remove registering here and register only in BackendManager.
| } | ||
|
|
||
| // Register cpu backend for static linking | ||
| #if defined(NGRAPH_BRIDGE_STATIC_LIB_ENABLE) |
Co-Authored-By: Shrestha Malik <shrestha.malik@intel.com>
sayantan-nervana
force-pushed
the
master
branch
from
367d3db to
d74ac48
Compare
4 participants
This PR fixes static build and static linking with recent ngraph core level changes