This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add AdaMax optimizer #243
Closed
Add AdaMax optimizer #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shashi456
reviewed
Jun 14, 2019
|
|
||
| static var allTests = [ | ||
| ("testAdaGrad", testAdaGrad), | ||
| ("testAdaMax", testAdaMax), |
Contributor
There was a problem hiding this comment.
Suggested change
| ("testAdaMax", testAdaMax), | |
| ("testAdaMax", testAdaMax) |
rxwei
reviewed
Jun 14, 2019
Contributor
Author
|
@rxwei Sure thing! I'll put a hold on it until further notice. |
Contributor
|
You actually didn't need to close this PR. Our optimizer refactoring will be ready in a day or two :) |
Contributor
Author
|
Unfortunately, this was the result of my inexperience with |
Contributor
|
No worries at all! A new PR sounds good. |
Contributor
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of AdaMax along with testing for correctness.
#127
Note: Build was broken with current macOS compiler (June 12, 2019 Snapshot) because of an unrelated call to
move(along:)in the RiemannSGD optimizer. Tests pass whenmoveis reverted tomoved.