This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add AdaMax optimizer #304
Merged
Add AdaMax optimizer #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
approved these changes
Jun 28, 2019
Contributor
saeta
left a comment
saeta
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Note: we might want to update some of the comments in a subsequent PR to be a bit easier to read when browsing auto-generated documentation.
Contributor
Contributor
|
Note: This PR didn't pass CI. |
Contributor
|
@rxwei you beat me to it, was just going to mention that :P |
Contributor
|
D'oh, sorry! :-( |
Contributor
Author
|
Is there anything I can help with to have this pass CI?
…On Fri, Jun 28, 2019 at 17:21 Brennan Saeta ***@***.***> wrote:
D'oh, sorry! :-(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#304?email_source=notifications&email_token=AJ355K67CRGPILPL3IL7Y23P4Z6GTA5CNFSM4H4DKPHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3GGQY#issuecomment-506880835>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ355K7YA7G24SBPJ4FUN2DP4Z6GTANCNFSM4H4DKPHA>
.
|
Contributor
|
This has been fixed by upstream PRs. Thanks for asking! |
Contributor
Author
|
No problem! Glad to hear it’s been resolved!
…On Fri, Jun 28, 2019 at 19:17 Richard Wei ***@***.***> wrote:
This has been fixed by upstream PRs. Thanks for asking!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#304?email_source=notifications&email_token=AJ355K77ROFL4QW4M5MGMRDP42LYXA5CNFSM4H4DKPHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3LUFY#issuecomment-506903063>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ355K73FIVPZHUDZNNQ2FLP42LYXANCNFSM4H4DKPHA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for AdaMax (WIP). This is a reopening of a previous PR on a branch that was accidentally deleted #243.