This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Support --t2t_usr_dir also in t2t-datagen #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noe
changed the title
--usr_dir also in t2t-datagen
noe
changed the title
rsepassi
reviewed
Jul 18, 2017
Contributor
rsepassi
left a comment
rsepassi
left a comment
There was a problem hiding this comment.
Thank you! One small edit requested, but otherwise looks good!
tensor2tensor/utils/usr_dir.py
Outdated
| import importlib | ||
| import tensorflow as tf | ||
|
|
||
| flags = tf.flags |
Contributor
There was a problem hiding this comment.
could you define the flag in the t2t-trainer as well as the t2t-datagen and have import_usr_dir take a usr_dir as an argument. yes, it'll be duplicated, but generally we try to keep flags in the main "binary" file.
Contributor
Author
There was a problem hiding this comment.
I've updated the PR with the requested changes.
rsepassi
pushed a commit
to rsepassi/tensor2tensor
that referenced
this pull request
Jul 19, 2017
PiperOrigin-RevId: 162389811
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #134 , it is now possible to add new problems by subclassing Problem and registering it, but there is no analogous mechanism to parameter
--t2t_usr_dirfromt2t-trainerwhich allows loading user-provided code. This PR simply consists in factoring out the functionality of--t2t_usr_dirout oft2t-trainerto a common place, and use it from botht2t-trainerandt2t-datagen.