This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Simplify adding new translation language pairs #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify wmt.py: `train_generator` is now a method (not a property returning a function) and WMTProblem subclasses implement it directly (not via one-purpose functions) * add WMT English-Czech translation problems * introduce `vocab_name` property, so e.g. `tokens.vocab-en-cs.32768` is used instead of `tokens.vocab.32768` if only English+Czech datasets were used
lukaszkaiser
approved these changes
Jul 25, 2017
Contributor
lukaszkaiser
left a comment
lukaszkaiser
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
train_generatoris now a method (not a property returning a function)and WMTProblem subclasses implement it directly (not via one-purpose functions)
vocab_nameproperty, so e.g.tokens.vocab-en-cs.32768is used instead oftokens.vocab.32768if only English+Czech datasets were used